Details
-
Improvement
-
Resolution: Unresolved
-
Minor
-
4.6.0, 5.0.0
Description
recordBackfillManagerBytesSent() and bufferedBackfill.bytes are the stats that are incremented when DCP items or meta items are read into readyQ and decremented when they are read out of readyQ. This accounting affects DCP flow control and DCP buffered backfill.
While they are currently accounted correctly, there is a huge possibility that they might get incremented more than decremented (or vice versa), due to any future changes. This is because lot of implicit things are assumed while incrementing and decrementing them, one being DcpResponse->getApproximateSize() being 0 for certain kind of DCP responses.
Hence, it is good to refactor to get clean accounting