Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-24905

DCP: Ensure recordBackfillManagerBytesSent() and bufferedBackfill.bytes are accounted cleanly to reduce scope of any future error

    XMLWordPrintable

Details

    Description

      recordBackfillManagerBytesSent() and bufferedBackfill.bytes are the stats that are incremented when DCP items or meta items are read into readyQ and decremented when they are read out of readyQ. This accounting affects DCP flow control and DCP buffered backfill.

      While they are currently accounted correctly, there is a huge possibility that they might get incremented more than decremented (or vice versa), due to any future changes. This is because lot of implicit things are assumed while incrementing and decrementing them, one being DcpResponse->getApproximateSize() being 0 for certain kind of DCP responses.

      Hence, it is good to refactor to get clean accounting

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            manu Manu Dhundi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty