Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-25152

fix xdcr stats names passed to UI

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Won't Do
    • 4.0.0, 4.5.0, 4.6.0, 5.0.0
    • None
    • XDCR
    • None
    • Untriaged
    • Unknown

    Description

      As described in the following doc,

      https://developer.couchbase.com/documentation/server/current/rest-api/rest-xdcr-statistics.html

      XDCR supports rest apis for retrieving xdcr runtime stats like the follows:

      http://172.23.121.61:8091/pools/default/buckets/default/stats/replications%2Fe6e0658726d50980bf5651970c939c6e%2Fdefault%2Ftarget%2Fdocs_written

      Things do not work for the following stats, though, since the stats name that xdcr passes to the UI are different from those described in the doc.

      rate_replication in doc   -> rate_replicated  actual

      docs_latency_wt in doc  -> wtavg_docs_latency

      meta_latency_wt in doc -> wtavg_meta_latency

      We need to change the stats names that xdcr passes to UI to match those in doc.

       

       

       

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Pavel Paulau Would it be a problem for you to modify the tests affected after the planned xdcr code change?

            yu Yu Sui (Inactive) added a comment - Pavel Paulau Would it be a problem for you to modify the tests affected after the planned xdcr code change?

            No, that's a small change.

             

            pavelpaulau Pavel Paulau (Inactive) added a comment - No, that's a small change.  

            Thanks for the confirmation. Will proceed with the plan.

            yu Yu Sui (Inactive) added a comment - Thanks for the confirmation. Will proceed with the plan.

            On second thought, it may not be easy or safe to change the stats name in xdcr. I now recall an earlier discussion from a long while back, when Ritesh was still with the company, where upgrade issue may arise. ns_server is already using the current xdcr stats name in their code. We could have ns_server change their code to use the new stats names. However, when the cluster is being upgraded, there could be the presence of both old and new stats names from different nodes in cluster, and it would be very difficult for ns_server to get things right. I believe that our conclusion then was that we should keep the stats names as they are, and change documentation to make things consistent. It seems that the documentation change has fallen through the crack somehow. Will close this bug and log a doc bug instead.

            yu Yu Sui (Inactive) added a comment - On second thought, it may not be easy or safe to change the stats name in xdcr. I now recall an earlier discussion from a long while back, when Ritesh was still with the company, where upgrade issue may arise. ns_server is already using the current xdcr stats name in their code. We could have ns_server change their code to use the new stats names. However, when the cluster is being upgraded, there could be the presence of both old and new stats names from different nodes in cluster, and it would be very difficult for ns_server to get things right. I believe that our conclusion then was that we should keep the stats names as they are, and change documentation to make things consistent. It seems that the documentation change has fallen through the crack somehow. Will close this bug and log a doc bug instead.

            Logged DOC-2541.

            yu Yu Sui (Inactive) added a comment - Logged DOC-2541 .

            People

              yu Yu Sui (Inactive)
              yu Yu Sui (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty