Details
-
Improvement
-
Resolution: Done
-
Minor
-
master
Description
The consructor is taking references then turning them into pointers, we should keep them as references as we never expect it to be null.
bgfetcher.h |
private: |
size_t doFetch(VBucket::id_type vbId, vb_bgfetch_queue_t& items); |
|
KVBucket* store; <-- should be reference
|
KVShard* shard; <- should be reference
|
size_t taskId; |
Constructor doing the conversion
BgFetcher::BgFetcher(KVBucket& s, KVShard& k)
|
: BgFetcher(&s, &k, s.getEPEngine().getEpStats()) {
|
}
|
Attachments
For Gerrit Dashboard: MB-25618 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
98778,20 | MB-25618: BgFetcher own references to KVBucket/KVShard | master | kv_engine | Status: MERGED | +2 | +1 |