Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-25618

BgFetcher should own references to KVBucket/KVShard

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Done
    • Minor
    • 6.5.0
    • master
    • couchbase-bucket

    Description

      The consructor is taking references then turning them into pointers, we should keep them as references as we never expect it to be null.

      bgfetcher.h

      private:
          size_t doFetch(VBucket::id_type vbId, vb_bgfetch_queue_t& items);
       
          KVBucket* store; <-- should be reference
          KVShard* shard; <- should be reference
          size_t taskId;
      

      Constructor doing the conversion

      BgFetcher::BgFetcher(KVBucket& s, KVShard& k)
          : BgFetcher(&s, &k, s.getEPEngine().getEpStats()) {
      }
      

      Attachments

        For Gerrit Dashboard: MB-25618
        # Subject Branch Project Status CR V

        Activity

          People

            ben.huddleston Ben Huddleston
            jwalker Jim Walker
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty