Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-25619

HashtableResizerTask should own reference to store

    XMLWordPrintable

Details

    Description

      The constructor and private member variable should be references as the KVBucketIface can never be null

      /**
       * Look around at hash tables and verify they're all sized
       * appropriately.
       */
      class HashtableResizerTask : public GlobalTask {
      public:
          HashtableResizerTask(KVBucketIface* s, double sleepTime); <- `s` should be reference
       
          bool run(void);
       
          cb::const_char_buffer getDescription() {
              return "Adjusting hash table sizes.";
          }
       
      private:
          KVBucketIface* store; <- should be reference
      };
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            sriram Sriram Ganesan (Inactive)
            jwalker Jim Walker
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty