Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
4.5.1, 5.0.0
Description
To improve our insight into how much work is being done during bg Fetches, it would be useful to record additional histograms:
- Count of read() calls per couchstore operation (i.e. per open() / close() pair).
- Number of read() calls issued per getMulti() call
- Number of read() calls issues per getMulti() call, per document - i.e. average reads for each document fetched.
Attachments
Gerrit Reviews
| For Gerrit Dashboard: MB-25661 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 82206,1 | MB-25661: FsStats: Add read count histogram | spock | kv_engine | Status: ABANDONED | 0 | -1 |
| 82208,2 | MB-25661: Add getMultiFsReadCount histograms | spock | kv_engine | Status: ABANDONED | 0 | -1 |
| 82212,2 | toy-daver-spock.xml: Add additional diagnostics to disk path | master | manifest | Status: MERGED | +2 | +1 |
| 82309,9 | MB-25661: FsStats: Add read() & write() count histograms | master | kv_engine | Status: MERGED | +2 | +1 |
| 82311,10 | MB-25661: Add getMultiFsReadCount histograms | master | kv_engine | Status: MERGED | +2 | +1 |
| 82404,5 | MB-25661: StatOps: implement get_stats() method | master | kv_engine | Status: MERGED | +2 | +1 |
| 82505,1 | MB-25661: Add count of bytes read to FileOpsInterface::FHStats | master | couchstore | Status: ABANDONED | 0 | -1 |
| 82568,4 | MB-25661: Rename io_read_bytes/num_read to io_bg_fetch_doc_bytes/num_read | master | kv_engine | Status: MERGED | +2 | +1 |
| 82569,5 | MB-25661: Statistics for background fetch read amplification | master | kv_engine | Status: MERGED | +2 | +1 |
Activity
Build 5.1.0-1119 contains kv_engine commit c26841872766357b0ad22ea342d398633339bfe6 with commit message:
MB-25661: StatOps: implement get_stats() method
https://github.com/couchbase/kv_engine/commit/c26841872766357b0ad22ea342d398633339bfe6
Build 5.1.0-1119 contains kv_engine commit f9550efe884333ae9e439b54a0e29710a75aa5b2 with commit message:
MB-25661: Add getMultiFsReadCount histograms
https://github.com/couchbase/kv_engine/commit/f9550efe884333ae9e439b54a0e29710a75aa5b2
Build 5.1.0-1134 contains kv_engine commit 45fa1633ae292bfc0cd3c708de1ae1ddc82a80e0 with commit message:
MB-25661: Rename io_read_bytes/num_read to io_bg_fetch_doc_bytes/num_read
https://github.com/couchbase/kv_engine/commit/45fa1633ae292bfc0cd3c708de1ae1ddc82a80e0
Build 5.1.0-1138 contains kv_engine commit 32797636997331d6bbcb08037ccce491022d46d4 with commit message:
MB-25661: Statistics for background fetch read amplification
https://github.com/couchbase/kv_engine/commit/32797636997331d6bbcb08037ccce491022d46d4
Build 5.1.0-1115 contains kv_engine commit ff989f3164424600f39363e00d500b359aa89ec0 with commit message:
MB-25661: FsStats: Add read() & write() count histogramshttps://github.com/couchbase/kv_engine/commit/ff989f3164424600f39363e00d500b359aa89ec0