Details
-
Improvement
-
Resolution: Done
-
Major
-
5.5.0
Description
Similar to previous cleanup MBs, we have a number of "old style" array new / delete[] in our codebase - a quick grep shows:
‡ git grep -- "delete\[\]"
|
daemon/breakpad_win32.cc: delete[] wc_minidump_dir;
|
engines/ep/src/couch-kvstore/couch-kvstore.cc: delete[] buffer;
|
engines/ep/src/couch-kvstore/couch-kvstore.cc: delete[] buffer;
|
engines/ep/src/defragmenter.cc: delete[] stats.ext_stats;
|
engines/ep/src/executorpool.cc: delete[] curWorkers;
|
engines/ep/src/executorpool.cc: delete[] numWorkers;
|
engines/ep/src/executorpool.cc: delete[] numReadyTasks;
|
engines/ep/src/ext_meta_parser.cc: delete[] data;
|
engines/ep/src/failover-table.cc: delete[] logentries;
|
engines/ep/src/memory_tracker.cc: delete[] stats.ext_stats;
|
engines/ep/src/mutation_log.h: delete[] mle;
|
engines/ep/src/storeddockey.h: delete[] reinterpret_cast<uint8_t*>(p);
|
tests/memory_tracking_test/memory_tracking_plugin.cc: delete[] ptr;
|
tests/memory_tracking_test/memory_tracking_test.cc: // Test new[] & delete[] //////////////////////////////////////////////
|
tests/memory_tracking_test/memory_tracking_test.cc: delete[] ptr;
|
We should audit these uses, in cases where they can be changed to std::vector<> we should do so.