Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-26262

cbdatasource.Close() might not be synchronous (according to code comments)

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Minor
    • None
    • master
    • cbdatasource
    • None

    Description

       

      According to this code:

       

      // TODO: By this point, worker goroutines may still be going, but
      // should end soon. Instead Close() should be 100% synchronous.
      return nil

       

      While running Sync Gateway integration tests in a loop where:

       

      • Flush bucket
      • Do sync gateway operations
      • Verify operations are successful
      • Repeat 

       

      We're seeing "DCP Rollback" warnings in the logs, and one theory is that there is residue from a previous test that is getting called back, possibly due to cbdatasource.Close() being asynchronous.

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            traun Traun Leyden (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty