Details
-
Bug
-
Resolution: Fixed
-
Major
-
5.5.0
-
Untriaged
-
Unknown
Description
UBSan complains about incorrect cast to derived in BinprotCommandT:
client_mcbp_commands.h:217:16: runtime error: downcast of address 0x7ffeefbfe5d0 which does not point to an object of type 'BinprotSaslAuthCommand'
|
0x7ffeefbfe5d0: note: object is of type 'BinprotCommandT<BinprotSaslAuthCommand, (unsigned char)33>'
|
I'm not totally sure this warning is accurate; the use of
static_cast<> here (CRTP) should be valid. However it (a) possibly
isn't, or (b) we are missing some RTTI information to allow UBSan to
check the cast.
Attachments
| For Gerrit Dashboard: MB-28744 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 91022,4 | MB-28744: UBSan: Remove static_cast from BinprotCommandT | master | kv_engine | Status: MERGED | +2 | +1 |