Details
-
Improvement
-
Resolution: Won't Do
-
Major
-
None
-
6.5.0
-
None
Description
The interface for CouchRocks (rocksdb-kvstore.h) #includes a number of <rocksdb> headers.
This is undesirable, this should be the interface to the integration; we shouldn't be forcing users of CouchRocks (i.e. ep.so) to include RocksDB headers directly.
We should move these #includes to the .cc file; making use of forward declarations of rocksdb types, or moving code which should be private to the .cc.