Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-28962

CouchRocks: Remove <rocksdb> headers from interface

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Do
    • Major
    • None
    • 6.5.0
    • couchbase-bucket
    • None

    Description

      The interface for CouchRocks (rocksdb-kvstore.h) #includes a number of <rocksdb> headers.

      This is undesirable, this should be the interface to the integration; we shouldn't be forcing users of CouchRocks (i.e. ep.so) to include RocksDB headers directly.

      We should move these #includes to the .cc file; making use of forward declarations of rocksdb types, or moving code which should be private to the .cc.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            owend Daniel Owen
            drigby Dave Rigby (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty