Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-29276

remove fts strings from cbgt's lean Cfg

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 5.5.0
    • 5.5.0
    • cbgt, fts
    • None
    • Untriaged
    • Unknown

    Description

      My bad as a code reviewer for missing this layering violation, but the cbgt library should not have any mention of FTS or CBFT – as that's only one particular application that's using the cbgt library.

      https://github.com/couchbase/cbgt/blob/master/cfg_metakv_lean.go#L40

      Looks like this was introduced in commit 8a140fa3, 2017/09/11, so it might have already gone production already in customer deployments?  (Need to double check on that.)  If so, that'd be unfortunately, and we'd need to carefully have a backwards compatibility maneuver to handle the mess.

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            apiravi Aruna Piravi (Inactive)
            steve Steve Yen
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty