Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-29507

Ensure Retry methods returns only one error and that is correctly handled

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 6.0.0
    • 5.5.0
    • eventing
    • None
    • Untriaged
    • Unknown

    Description

      In fixing MB-28667, we chose to add a new return value to handle timeout during retry as we didn't want to change all error handling paths as it was too big a change at that point in the release. This bug is to ensure:

      (a) common.Timeout is changed to type "error" and is returned as a normal error, i.e.:
      CallbackFunc func(arg ...interface{}) error in util.go

      (b) Every call to util.Retry must either handle the returned error, or propogate it up to parent. If an error must be ignored, then we should log it at some suitable log level – so it is clear we are ignoring it explicitly.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              Gautham.Banasandra Gautham Banasandra (Inactive)
              siri Sriram Melkote (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty