Details
-
Bug
-
Resolution: Fixed
-
Critical
-
5.0.0, 5.5.0, 6.5.0
-
Untriaged
-
Yes
Description
We used to have the logic by which the UI would send /controller/stopRebalance request with onlyIfSafe=1 query parameter. ns_server would handle the request normally unless it decided that it couldn't handle the request safely. In such case, it would return an error, the UI would show a confirmation dialog asking the user to confirm the operation. See http://review.couchbase.org/#/c/28883/3/priv/public/js/servers.js for the details.
This was silently removed together with the old UI. We need to resurrect this logic.
I took a liberty to make "safe" option the default. Just like with failover, the UI would get an error with 504 status if the operation is deemed unsafe. It needs to pass allowUnsafe=true to confirm the operation. It's probably also fine to use the same confirmation dialog as for the failover. See http://review.couchbase.org/#/c/95219/ for details.
Attachments
| For Gerrit Dashboard: MB-29980 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 95302,3 | MB-29980: reanimate stopRebalance confirmation dialog | vulcan | ns_server | Status: MERGED | +2 | +1 |
| 95318,3 | MB-29980 allowUnsafe set to true for failover & stopRebalance | master | couchbase-cli | Status: MERGED | +2 | +1 |
| 95338,1 | Merge remote-tracking branch 'couchbase/vulcan' | master | ns_server | Status: MERGED | +2 | +1 |
| 111231,3 | MB-29980: add missed dependency | master | ns_server | Status: MERGED | +2 | +1 |