Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-31070 AppendPrepend makes expire 0
  3. MB-31585

[BP 5.5.3] - AppendPrepend makes expire 0

    XMLWordPrintable

Details

    • Technical task
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 5.0.0, 5.1.0, 5.0.1, 5.1.1, 5.5.0, 5.5.1
    • 5.5.3
    • memcached

    Description

      Backport of MB-31070 to 5.5.3

      repro:

      1. save document with expires
      2. append something
      3. expires is now 0

      one way to see expires:
      http://localhost:8091/pools/default/buckets/BUCKET1/docs/KEY1

      {
          "meta": {
              "id": "KEY1",
              "rev": "82403-154eb8606b8900000000000000000000",
              "att_reason": "invalid_json",
              "expiration": 0,
              "flags": 0
          },
          "base64": ...
      }
      

      we believe, the root of the problem is in this line:
      https://github.com/couchbase/kv_engine/blob/0185d9fe79d5aa705ed113184f9436d6f7215325/daemon/protocol/mcbp/appendprepend_context.cc#L187

      It just needs to be "oldItemInfo.exptime"

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Build couchbase-server-5.5.3-4006 contains kv_engine commit d52ef35 with commit message:
          Merge "MB-31585: Merge remote-tracking branch 'couchbase/spock' into vulcan" into vulcan

          build-team Couchbase Build Team added a comment - Build couchbase-server-5.5.3-4006 contains kv_engine commit d52ef35 with commit message: Merge " MB-31585 : Merge remote-tracking branch 'couchbase/spock' into vulcan" into vulcan

          Build couchbase-server-5.5.3-4006 contains kv_engine commit daf1f8f with commit message:
          MB-31585: Merge remote-tracking branch 'couchbase/spock' into vulcan

          build-team Couchbase Build Team added a comment - Build couchbase-server-5.5.3-4006 contains kv_engine commit daf1f8f with commit message: MB-31585 : Merge remote-tracking branch 'couchbase/spock' into vulcan

          Build couchbase-server-6.0.1-1970 contains kv_engine commit d52ef35 with commit message:
          Merge "MB-31585: Merge remote-tracking branch 'couchbase/spock' into vulcan" into vulcan

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.0.1-1970 contains kv_engine commit d52ef35 with commit message: Merge " MB-31585 : Merge remote-tracking branch 'couchbase/spock' into vulcan" into vulcan

          Build couchbase-server-6.0.1-1970 contains kv_engine commit daf1f8f with commit message:
          MB-31585: Merge remote-tracking branch 'couchbase/spock' into vulcan

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.0.1-1970 contains kv_engine commit daf1f8f with commit message: MB-31585 : Merge remote-tracking branch 'couchbase/spock' into vulcan

          Build couchbase-server-6.5.0-1707 contains kv_engine commit d52ef35 with commit message:
          Merge "MB-31585: Merge remote-tracking branch 'couchbase/spock' into vulcan" into vulcan

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-1707 contains kv_engine commit d52ef35 with commit message: Merge " MB-31585 : Merge remote-tracking branch 'couchbase/spock' into vulcan" into vulcan

          Build couchbase-server-6.5.0-1707 contains kv_engine commit daf1f8f with commit message:
          MB-31585: Merge remote-tracking branch 'couchbase/spock' into vulcan

          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-1707 contains kv_engine commit daf1f8f with commit message: MB-31585 : Merge remote-tracking branch 'couchbase/spock' into vulcan

          People

            trond Trond Norbye
            drigby Dave Rigby
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty