Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-31619

memcached logs always use Z (UTC) for timezone when logging

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 6.0.0, 5.5.0, 5.5.1, 5.5.2
    • Fix Version/s: 6.0.0
    • Component/s: memcached
    • Labels:
      None
    • Triage:
      Untriaged
    • Is this a Regression?:
      Unknown

      Description

      It looks like some recent changes in the memcached logging has caused the timezone in the memcached logs to be always printed with Z, referring to UTC, even when the timezone of the system (and other logs) is different.

      Looks like the "Z" is hard coded here https://github.com/couchbase/kv_engine/blob/master/logger/spdlogger.cc#L44

      Note the time is not actually converted to UTC, it is still using the system's local timezone. This is misleading as the reader may (quite reasonably) think the log message refers to UTC and hence struggle to correlate log messages.

        Attachments

        For Gerrit Dashboard: MB-31619
        # Subject Branch Project Status CR V

          Activity

          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-5.5.3-4005 contains kv_engine commit c33f0c1 with commit message:
          MB-31636: Print correct timezone in log messages

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-5.5.3-4005 contains kv_engine commit c33f0c1 with commit message: MB-31636 : Print correct timezone in log messages
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-6.5.0-1447 contains kv_engine commit 6d2735a with commit message:
          Merge remote-tracking branch 'couchbase/alice'

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-1447 contains kv_engine commit 6d2735a with commit message: Merge remote-tracking branch 'couchbase/alice'
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-6.5.0-1447 contains kv_engine commit d0c17cc with commit message:
          MB-31619: Print correct timezone in log messages

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-1447 contains kv_engine commit d0c17cc with commit message: MB-31619 : Print correct timezone in log messages
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-6.0.1-1970 contains kv_engine commit c33f0c1 with commit message:
          MB-31636: Print correct timezone in log messages

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-6.0.1-1970 contains kv_engine commit c33f0c1 with commit message: MB-31636 : Print correct timezone in log messages
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-6.5.0-1707 contains kv_engine commit c33f0c1 with commit message:
          MB-31636: Print correct timezone in log messages

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-6.5.0-1707 contains kv_engine commit c33f0c1 with commit message: MB-31636 : Print correct timezone in log messages

            People

            • Assignee:
              drigby Dave Rigby
              Reporter:
              david.saadeh David Saadeh
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty

                  Error rendering 'com.pagerduty.jira-server-plugin:PagerDuty'. Please contact your Jira administrators.