Details
-
Task
-
Resolution: Fixed
-
Critical
-
6.5.0
-
None
-
KV-Engine Mad-Hatter GA
Description
We should set the CB_DEVELOPMENT_ASSERTS flag ON to fire development only assertions. In particular this ensure things such as the vBucket document counter and vBucket dirtyQueueSize do not end up in incorrect states.
When we branch master (Mad-Hatter) to its own branch we need to set the CB_DEVELOPMENT_ASSERTS flag in tlm/CmakeLists.txt to Off. This ensures that any development assertions will not fire in release/release candidate builds. We want this flag to be set to On until this point though, as the assertions can help identify issues that we may not otherwise see.
Attachments
Issue Links
- is cloned by
-
-
- Resolved
-
| For Gerrit Dashboard: MB-31797 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 101546,3 | MB-31797: Set CB_DEVELOPMENT_ASSERTS ON | master | tlm | Status: MERGED | +2 | +1 |
| 101547,5 | MB-31797: Correct tracking of vBucket states in vbStateCount | master | kv_engine | Status: MERGED | +2 | +1 |
| 101548,4 | MB-31797: Correct vbStateCount array indexing with offset | master | kv_engine | Status: MERGED | +2 | +1 |
| 101549,4 | MB-31797: GetItemsToPersist_Limit does not inc BackfillQSize | master | kv_engine | Status: MERGED | +2 | +1 |
| 101550,4 | MB-31797: Correct VBucketFullEvictionTest MB_31037 stat tracking | master | kv_engine | Status: MERGED | +2 | +1 |
| 101551,4 | MB-31797: Make RocksDB assume deletions are for non-existing items | master | kv_engine | Status: MERGED | +2 | +1 |
| 101588,7 | MB-31797: Set CB_DEVELOPMENT_ASSERTS ON | master | platform | Status: MERGED | +2 | +1 |
| 117741,2 | MB-31797: Explicitly specify ThrowExceptionPolicy | mad-hatter | kv_engine | Status: MERGED | +2 | +1 |
| 117742,1 | MB-31797: Set CB_DEVELOPMENT_ASSERTS to OFF | master | tlm | Status: ABANDONED | -2 | +1 |
| 117784,1 | Merge branch 'mad-hatter' | master | kv_engine | Status: MERGED | +2 | +1 |
| 117798,2 | MB-31797: Set CB_DEVELOPMENT_ASSERTS to OFF | mad-hatter | tlm | Status: MERGED | +2 | +1 |
| 119673,2 | Merge branch 'couchbase/mad-hatter' | master | tlm | Status: MERGED | +2 | +1 |