KV should warmup dead and pending vbuckets

History of this MB can be tracked back through

• MB-35407
• MB-35326

This MB tracks KV reverting a patch which skips the warmup of dead vbuckets.

If we apply the following state transitions and don't warmup

• active -> dead -> replica

The data in the active VB is still in the replica, dead doesn't imply delete.

If we apply the following state transitions and do warmup

• active -> dead -> warmup -> replica

The replica vbucket is empty because KV warmup ignores the data, ns_server tells KV to create a replica vbucket and we do, but empty and requiring a full rebuild. This is not ideal, certainly if the rebuild is slow/failing or a active node failure occurs.

This was first introduced in 5.0 patch See comment below - goes back to 3.0.

Initial plan is to revert in MH.