Details
-
Bug
-
Resolution: Fixed
-
Critical
-
6.5.0
-
Triaged
-
No
-
KV-Engine MH 2nd Beta, KV-Engine Mad-Hatter GA
Description
If we shutdown then warmup mid-snapshot (that contains a prepare) then post warmup we will expose a HPS value that is invalid as the replica has not received a full snapshot. We should only move the HPS value on complete snapshots.
Say we receive a memory snapshot marker with snap start of 1 and snap end of 2. We receive a prepare at seqno 1. If we crash and warmup after persisting seqno 1 but not 2 then we will set the HPS value to 1 which is incorrect and breaks durability constraints. Before crashing our in-memory HPS would remain at 0 as we need an entire sanpshot to move the HPS.
Attachments
Issue Links
- relates to
-
MB-35308 HPS does not move for non-durable writes
- Closed
For Gerrit Dashboard: MB-36133 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
117869,3 | MB-36765: Revert "MB-35308: Move HPS on non durable writes" | mad-hatter | kv_engine | Status: MERGED | +2 | +1 |
117910,19 | MB-36133: Persist highPreparedSeqno | mad-hatter | kv_engine | Status: MERGED | +2 | +1 |
118191,1 | Merge branch 'couchbase/mad-hatter' into 'couchbase/master' | master | kv_engine | Status: MERGED | +2 | +1 |