Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-36327

AddressSanitizer issue: SEGV in github.com/couchbase/gomemcached/client.(*UprFeed).initStreamType

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • master
    • master
    • gomemcached
    • None
    • Untriaged
    • Yes

    Description

      As seen during KV-Engine post-commit master job (with AddressSanitizer enabled):

      ==23175==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x0000006f0d4e bp 0x10c000a9eb58 sp 0x10c000a9eb00 T5)
      ==23175==The signal is caused by a READ memory access.
      ==23175==Hint: address points to the zero page.
          #0 0x6f0d4d in github.com/couchbase/gomemcached/client.(*UprFeed).initStreamType (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/goxdcr+0x6f0d4d)
       
      AddressSanitizer can not provide additional info.
      SUMMARY: AddressSanitizer: SEGV (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/goxdcr+0x6f0d4d) in github.com/couchbase/gomemcached/client.(*UprFeed).initStreamType
      Thread T5 created by T4 here:
          #0 0x7fc017cbaa00 in __interceptor_pthread_create (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/../lib/libasan.so.4+0x36a00)
          #1 0x96d42f in _cgo_try_pthread_create (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/goxdcr+0x96d42f)
          #2 0x7fffff in html/template.escapeTemplate (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/goxdcr+0x7fffff)
       
      Thread T4 created by T2 here:
          #0 0x7fc017cbaa00 in __interceptor_pthread_create (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/../lib/libasan.so.4+0x36a00)
          #1 0x96d42f in _cgo_try_pthread_create (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/goxdcr+0x96d42f)
          #2 0x7fffff in html/template.escapeTemplate (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/goxdcr+0x7fffff)
       
      Thread T2 created by T0 here:
          #0 0x7fc017cbaa00 in __interceptor_pthread_create (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/../lib/libasan.so.4+0x36a00)
          #1 0x96d42f in _cgo_try_pthread_create (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/goxdcr+0x96d42f)
          #2 0x7fffff in html/template.escapeTemplate (/home/couchbase/jenkins/workspace/kv_engine-master-post-commit/install/bin/goxdcr+0x7fffff)
       
      ==23175==ABORTING
      

      Full log: http://cv.jenkins.couchbase.com/job/kv_engine-master-post-commit/2344/consoleFull#2057882369b106e815-6d27-4a01-8b14-4b94513c99be

      Full changelog since last good build: http://cv.jenkins.couchbase.com/job/kv_engine-master-post-commit/2344/changes

      Appears to be related to this patch: http://review.couchbase.org/#/c/115620/ (MB-36061).

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          drigby Dave Rigby added a comment -

          Assigning to Neil Huang as the author of the suspected problematic patch.

          drigby Dave Rigby added a comment - Assigning to Neil Huang as the author of the suspected problematic patch.
          neil.huang Neil Huang added a comment - - edited

          From what I understand, this is on the master branch of gomemcached.

          Based on MB-36275, gomemcached has a MH branch and MH manifest will be picking up that branch, so this should affect only CC. (Thus, the fix should only be checked into master and not the MH branch)

          Please correct me if I'm wrong.

          neil.huang Neil Huang added a comment - - edited From what I understand, this is on the master branch of gomemcached. Based on  MB-36275 , gomemcached has a MH branch and MH manifest will be picking up that branch, so this should affect only CC. (Thus, the fix should only be checked into master and not the MH branch) Please correct me if I'm wrong.
          drigby Dave Rigby added a comment -

          From what I understand, this is on the master branch of gomemcached.
          Based on MB-36275, gomemcached has a MH branch and MH manifest will be picking up that branch, so this should affect only CC.

          True, however many developers work on master / automated testing is run on master. We cannot have master branch broken for any amount of time - it's not like we can wait 12 months (Cheshire-Cat release timeframe) to fix this.

          KV-Engine's post-commit job is currently failing due to this so if any additional regressions were introduced we wouldn't detect them.

          drigby Dave Rigby added a comment - From what I understand, this is on the master branch of gomemcached. Based on MB-36275 , gomemcached has a MH branch and MH manifest will be picking up that branch, so this should affect only CC. True, however many developers work on master / automated testing is run on master. We cannot have master branch broken for any amount of time - it's not like we can wait 12 months (Cheshire-Cat release timeframe) to fix this. KV-Engine's post-commit job is currently failing due to this so if any additional regressions were introduced we wouldn't detect them.

          I suggest xdcr team start running make simple-test on master for each commit, the same way as we do.

          artem Artem Stemkovski added a comment - I suggest xdcr team start running make simple-test on master for each commit, the same way as we do.

          Build couchbase-server-7.0.0-1003 contains gomemcached commit 7b5da2e with commit message:
          MB-36327 - check for nil collection filter

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-1003 contains gomemcached commit 7b5da2e with commit message: MB-36327 - check for nil collection filter

          No issues in latest runs.

          pavithra.mahamani Pavithra Mahamani added a comment - No issues in latest runs.

          Build sync_gateway-3.0.0-2 contains gomemcached commit 7b5da2e with commit message:
          MB-36327 - check for nil collection filter

          build-team Couchbase Build Team added a comment - Build sync_gateway-3.0.0-2 contains gomemcached commit 7b5da2e with commit message: MB-36327 - check for nil collection filter

          People

            neil.huang Neil Huang
            drigby Dave Rigby
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty