Details
-
Bug
-
Resolution: Fixed
-
Major
-
Cheshire-Cat
-
Untriaged
-
Unknown
Description
Magma has explicit compactions triggered by kvstore API call compactDB. It also has implicit compactions trigger by certain conditions within magma. Sometimes those implicit compactions can overlap with explicit compactions and pick up the compaction context. We need to make a copy of the compaction_ctx and when compactions see the compaction_ctx, they need to allocate their own copy of the eraserContext.
Attachments
Issue Links
- blocks
-
MB-36371 Allow implicit magma compactions to expire documents and purge tombstone
- Closed
For Gerrit Dashboard: MB-37739 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
121235,11 | MB-37739: Refactor magma compaction to copy compaction_ctx | master | kv_engine | Status: ABANDONED | 0 | -1 |
123578,6 | MB-37739 magma: Refactor CompactKVStore | master | magma | Status: MERGED | +2 | +1 |
123583,11 | MB-37739 magma: Use explicit compaction context during CompactKVStore | master | magma | Status: MERGED | +2 | +1 |
124121,13 | MB-37739: Refactor the usage of cachedVBStates and cachedMagmaInfo | master | kv_engine | Status: MERGED | +2 | +1 |
124785,33 | MB-37739: Use MagmaDbStats | master | kv_engine | Status: MERGED | +2 | +1 |
125937,3 | MB-37739 lsm: Do not hold mutex while creating compaction context | master | magma | Status: MERGED | +2 | +1 |
126018,9 | MB-37739: Make EPBucket::makeCompactionContext return shared_ptr | master | kv_engine | Status: MERGED | +2 | +1 |
126019,10 | MB-37739: Make compactDB API take shared_ptr compaction_ctx | master | kv_engine | Status: MERGED | +2 | +1 |
126020,9 | MB-37739: Initialize shards for MockEPBucket | master | kv_engine | Status: MERGED | +2 | +1 |
126021,7 | MB-37739: Remove MagmaCompactionCtx | master | kv_engine | Status: ABANDONED | +1 | -1 |
126022,13 | MB-37739: Add MagmaDbStats | master | kv_engine | Status: MERGED | +2 | +1 |
126257,1 | WIP MB-37739: Add support for implicit magma compaction | master | kv_engine | Status: ABANDONED | 0 | -1 |
126320,10 | MB-37739: Generate new compaction_ctx for implicit compactions | master | kv_engine | Status: MERGED | +2 | +1 |
126321,13 | MB-37739: Use MagmaDBStats in compaction | master | kv_engine | Status: MERGED | +2 | +1 |
126389,9 | MB-37739: Cleanup old magma-kvstore code | master | kv_engine | Status: MERGED | +2 | +1 |