Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-38662

cbbackupmgr shouldn't use the 'filepath' module for getting keys in AWS

    XMLWordPrintable

Details

    Description

      The way that we translate paths in the staging directory to keys in S3 is by using the 'filepath' module; this is incorrect. The 'filepath' module is platform specific and will produce different output depending on the OS. We should be using the 'path' module since this more correctly suits this purpose.

      We should also ensure that when constructing keys (with are not local paths) that we use the 'path' module instead of 'filepath'. An example case would be when we are deleting a rotated logfile; we are not converting a key from the local staging directory into a key in aws, we are constructing a key from the archive. Instead of doing 'filepath.Join(archive, "logs", "backup-0.log")', we should use 'path.Join(archive, "logs", "backup-0.log")'

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            james.lee James Lee
            james.lee James Lee
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty