Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-39420

[BP 6.6.0] - Re-generate protobuf files (.pb.go) files when .proto files are updated

    XMLWordPrintable

    Details

    • Triage:
      Untriaged
    • Is this a Regression?:
      Unknown

      Description

      The protobuf files indexer uses are not re-generated every time there has been an updated to the corresponding .proto files. This is because the protoc command gets executed only when the output of add_custom_command is out dated compared to the files it depends on.

      Currently, add_custom_command depends on secondary/protobuf whose timestamp does not get updated when updating an existing file

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

            Hide
            jeelan.poola Jeelan Poola added a comment -

            Till WestmannMihir Kamdar This fix must be back ported as it may result in inconvenience to developers working on mad-hatter branch. I expect the product to not have any impact as official builds are done from scratch. Few developers ran into this issue during their local builds.

            Show
            jeelan.poola Jeelan Poola added a comment - Till Westmann Mihir Kamdar This fix must be back ported as it may result in inconvenience to developers working on mad-hatter branch. I expect the product to not have any impact as official builds are done from scratch. Few developers ran into this issue during their local builds.
            Hide
            mihir.kamdar Mihir Kamdar added a comment -

            Sure Jeelan Poola, lets take it. Is this something that can be verified on a dev environment?

            Show
            mihir.kamdar Mihir Kamdar added a comment - Sure Jeelan Poola , lets take it. Is this something that can be verified on a dev environment?
            Hide
            deepkaran.salooja Deepkaran Salooja added a comment -

            Mihir Kamdar, yes this can be easily verified on a dev environment.

            Show
            deepkaran.salooja Deepkaran Salooja added a comment - Mihir Kamdar , yes this can be easily verified on a dev environment.
            Hide
            build-team Couchbase Build Team added a comment -

            Build couchbase-server-6.6.0-7644 contains indexing commit 7f2c139 with commit message:
            MB-39420 Re-generate protobuf files (.pb.go) when .proto files are updated

            Show
            build-team Couchbase Build Team added a comment - Build couchbase-server-6.6.0-7644 contains indexing commit 7f2c139 with commit message: MB-39420 Re-generate protobuf files (.pb.go) when .proto files are updated
            Hide
            varun.velamuri Varun Velamuri added a comment -

            Hemant Rajput, you can close this based on dev verification

            Show
            varun.velamuri Varun Velamuri added a comment - Hemant Rajput , you can close this based on dev verification
            Hide
            hemant.rajput Hemant Rajput added a comment -

            closing issue based on Dev's testing.

            Show
            hemant.rajput Hemant Rajput added a comment - closing issue based on Dev's testing.

              People

              Assignee:
              varun.velamuri Varun Velamuri
              Reporter:
              deepkaran.salooja Deepkaran Salooja
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes

                    PagerDuty