Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-40577

Dropping a dataset with an non-existent dataverse returns error 24034 (cannot find dataverse) in 6.6, but a "cannot find dataset" error in 6.5

    XMLWordPrintable

    Details

    • Triage:
      Untriaged
    • Story Points:
      1
    • Is this a Regression?:
      Yes
    • Sprint:
      CX Sprint 209

      Description

      We (Java SDK folk) are now running our CI tests against 6.6, which has found this minor regression.

      The test is:

      @Test
      void dropDatasetFailsIfAbsent() {
          assertThrows(DatasetNotFoundException.class, () -> analytics.dropDataset("foo",
            dropDatasetAnalyticsOptions()
                .dataverseName("absentDataverse")));
      }
       

      In 6.6 this now fails as it raises a DataverseNotFoundException rather than DatasetNotFoundException, as cbas now returns a 24034 code.  In this test and the one below too, neither "foo" nor "absentDataverse" exist.

      This causes problems for our `ignoreIfNotExist` option, which allows dropping datasets and silently ignoring if they don't exist.  Because that logic is expecting a DataverseNotFoundException. 

      E.g. this other test fails with a DataverseNotFoundException, when you would expect it to succeed.  This test also passed in 6.5.

      @Test
      void dropDatasetCanIgnoreAbsent() {
        analytics.dropDataset("foo",
            dropDatasetAnalyticsOptions()
                .ignoreIfNotExists(true)
                .dataverseName("absentDataverse"));
      }
       

       For both tests, if I don't specify a dataverseName then the tests pass as expected.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          graham.pople Graham Pople added a comment -

          Ok Dmitry Lychagin, I'll let the team know and let you know if they have any feedback.  That sounds ok to me though, I'll modify these tests accordingly.  MB-40576 is more of a problem as we'll have to find some way of disabling the analytics tests, or a subset of them, but only on 6.6.0.

          Show
          graham.pople Graham Pople added a comment - Ok Dmitry Lychagin , I'll let the team know and let you know if they have any feedback.  That sounds ok to me though, I'll modify these tests accordingly.   MB-40576 is more of a problem as we'll have to find some way of disabling the analytics tests, or a subset of them, but only on 6.6.0.
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-6.6.0-7896 contains cbas-core commit c23928d with commit message:
          MB-40577: DROP DATASET IF EXISTS must not fail if dataverse not found

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-6.6.0-7896 contains cbas-core commit c23928d with commit message: MB-40577 : DROP DATASET IF EXISTS must not fail if dataverse not found
          Hide
          will.broadbelt Will Broadbelt added a comment -

          Verified tests pass with 6.6.0-7897.

          Show
          will.broadbelt Will Broadbelt added a comment - Verified tests pass with 6.6.0-7897.
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-7.0.0-2746 contains cbas-core commit c23928d with commit message:
          MB-40577: DROP DATASET IF EXISTS must not fail if dataverse not found

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.0-2746 contains cbas-core commit c23928d with commit message: MB-40577 : DROP DATASET IF EXISTS must not fail if dataverse not found
          Hide
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-6.6.2-9599 contains cbas-core commit c23928d with commit message:
          MB-40577: DROP DATASET IF EXISTS must not fail if dataverse not found

          Show
          build-team Couchbase Build Team added a comment - Build couchbase-server-6.6.2-9599 contains cbas-core commit c23928d with commit message: MB-40577 : DROP DATASET IF EXISTS must not fail if dataverse not found

            People

            Assignee:
            will.broadbelt Will Broadbelt
            Reporter:
            graham.pople Graham Pople
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Due:
              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes

                  PagerDuty