Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-47763

XDCR - backfill req handler may not get correct throughSeqnos if pipeline is paused

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 7.0.0, 7.1.0
    • 7.1.0
    • XDCR
    • Untriaged
    • 1
    • No

    Description

      For 7.0, we have the following lines:

      https://github.com/couchbase/goxdcr/blob/d90bca90e8195c66250c434418825c744216420a/backfill_manager/backfill_request_handler.go#L440-L445

      Normally, when raising a backfill, XDCR will go figure out the throughSeqno and compile a backfill task for each VB going from 0 to whatever the throughSeqno is.

      When the pipeline is stopped and not running, it will retrieve 0. Instead, it should follow the other path of 

      https://github.com/couchbase/goxdcr/blob/d90bca90e8195c66250c434418825c744216420a/backfill_manager/backfill_request_handler.go#L867

      and capture checkpoint number, in case the pipeline is stopped.

      For 7.0, it's not a huge issue because the first call only happens during pipeline runtime. (Can consider this for backport just in case).

      However, this is a hole that should be fixed in preparation for 7.1 and the MB-9982 work.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Build couchbase-server-7.1.0-1119 contains goxdcr commit 7e1dae2 with commit message:
            MB-47763 - backfill req handler may not get correct throughSeqnos if pipeline is paused

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1119 contains goxdcr commit 7e1dae2 with commit message: MB-47763 - backfill req handler may not get correct throughSeqnos if pipeline is paused

            People

              neil.huang Neil Huang
              neil.huang Neil Huang
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty