Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-47779

[BP 7.0.2] - XDCR - backfill req handler may not get correct throughSeqnos if pipeline is paused

    XMLWordPrintable

Details

    • Untriaged
    • 1
    • No

    Description

      For 7.0, we have the following lines:

      https://github.com/couchbase/goxdcr/blob/d90bca90e8195c66250c434418825c744216420a/backfill_manager/backfill_request_handler.go#L440-L445

      Normally, when raising a backfill, XDCR will go figure out the throughSeqno and compile a backfill task for each VB going from 0 to whatever the throughSeqno is.

      When the pipeline is stopped and not running, it will retrieve 0. Instead, it should follow the other path of 

      https://github.com/couchbase/goxdcr/blob/d90bca90e8195c66250c434418825c744216420a/backfill_manager/backfill_request_handler.go#L867

      and capture checkpoint number, in case the pipeline is stopped.

      For 7.0, it's not a huge issue because the first call only happens during pipeline runtime. (Can consider this for backport just in case).

      However, this is a hole that should be fixed in preparation for 7.1 and the MB-9982 work.

      Attachments

        Issue Links

          For Gerrit Dashboard: MB-47779
          # Subject Branch Project Status CR V

          Activity

            neil.huang Neil Huang created issue -
            neil.huang Neil Huang made changes -
            Field Original Value New Value
            Link This issue Clones MB-47763 [ MB-47763 ]
            neil.huang Neil Huang made changes -
            Link This issue is a backport of MB-47763 [ MB-47763 ]
            neil.huang Neil Huang made changes -
            Link This issue Clones MB-47763 [ MB-47763 ]
            neil.huang Neil Huang made changes -
            Affects Version/s Neo [ 17615 ]
            neil.huang Neil Huang made changes -
            Fix Version/s 7.0.1 [ 17104 ]
            Fix Version/s Neo [ 17615 ]
            wayne Wayne Siu made changes -
            Link This issue blocks MB-46308 [ MB-46308 ]
            wayne Wayne Siu made changes -
            Labels backport-candidate approved-for-7.0.1

            Build couchbase-server-7.0.1-5995 contains goxdcr commit 8a49a40 with commit message:
            MB-47779 - backfill req handler may not get correct throughSeqnos if pipeline is paused

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.1-5995 contains goxdcr commit 8a49a40 with commit message: MB-47779 - backfill req handler may not get correct throughSeqnos if pipeline is paused
            neil.huang Neil Huang made changes -
            Assignee Neil Huang [ neil.huang ] Pavithra Mahamani [ pavithra.mahamani ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            lynn.straus Lynn Straus made changes -
            Fix Version/s 7.0.2 [ 18012 ]
            lynn.straus Lynn Straus made changes -
            Fix Version/s 7.0.1 [ 17104 ]
            pavithra.mahamani Pavithra Mahamani (Inactive) made changes -
            Labels approved-for-7.0.1 approved-for-7.0.1 request-dev-verify
            pavithra.mahamani Pavithra Mahamani (Inactive) made changes -
            Assignee Pavithra Mahamani [ pavithra.mahamani ] Neil Huang [ neil.huang ]
            neil.huang Neil Huang made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            ianmccloy Ian McCloy made changes -
            Summary [BP 7.0.1] - XDCR - backfill req handler may not get correct throughSeqnos if pipeline is paused [BP 7.0.2] - XDCR - backfill req handler may not get correct throughSeqnos if pipeline is paused

            People

              neil.huang Neil Huang
              neil.huang Neil Huang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty