Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-47817

Test eventing with libcouchbase 3.2.2 and update build to use this

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 7.1.0
    • clients, eventing
    • None
    • 1

    Description

      In order to pick up various fixes and prepare to pick up later changes such as those under CCBC-1411, please test eventing with libcouchbase 3.2.latest and update the manifest accordingly.

      While these haven't been found in eventing testing, there are a few important issues targeting the 3.2.1 of libcouchbase, which is expected to be available in the August cadence. See the releases in JIRA for details on content.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            ankit.prabhu Ankit Prabhu added a comment - - edited

            I tried building the toy(libcouchbase 3.2.2) after removing '-Wmissing-braces' (http://review.couchbase.org/c/tlm/+/162436))
            The build succeeded http://server.jenkins.couchbase.com/view/Toys/job/toy-unix-simple/3634/consoleFull

            ankit.prabhu Ankit Prabhu added a comment - - edited I tried building the toy(libcouchbase 3.2.2) after removing '-Wmissing-braces' ( http://review.couchbase.org/c/tlm/+/162436) ) The build succeeded http://server.jenkins.couchbase.com/view/Toys/job/toy-unix-simple/3634/consoleFull

            Thank you Ray Cardillo!

            Spoke with Chris Hillery and requested him to help with a way to remove -Wmissing-braces option while building libcouchbase as part of Server build. Hoping we can make it work across all compilers including MSVC.

            Ankit Prabhu Could you please help test the patch from Ceej once it's available? Thank you!

            jeelan.poola Jeelan Poola added a comment - Thank you Ray Cardillo ! Spoke with Chris Hillery and requested him to help with a way to remove -Wmissing-braces option while building libcouchbase as part of Server build. Hoping we can make it work across all compilers including MSVC. Ankit Prabhu Could you please help test the patch from Ceej once it's available? Thank you!

            I've proposed http://review.couchbase.org/c/tlm/+/162439 which fixes the build breakage in my local testing. It shouldn't interfere with non-gcc/clang build scenarios, and it doesn't appear that we enable the MSVC equivalent of -Werror=no-braces, so I believe it's safe.

            ceej Chris Hillery added a comment - I've proposed http://review.couchbase.org/c/tlm/+/162439  which fixes the build breakage in my local testing. It shouldn't interfere with non-gcc/clang build scenarios, and it doesn't appear that we enable the MSVC equivalent of -Werror=no-braces, so I believe it's safe.

            My tlm change is in now, which should fix the build problem. Back to Ankit for functionality verification.

            ceej Chris Hillery added a comment - My tlm change is in now, which should fix the build problem. Back to Ankit for functionality verification.

            Build couchbase-server-7.1.0-1378 contains tlm commit 2d1ec10 with commit message:
            MB-47817: Disable missing-braces check when building libcouchbase

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1378 contains tlm commit 2d1ec10 with commit message: MB-47817 : Disable missing-braces check when building libcouchbase

            People

              ankit.prabhu Ankit Prabhu
              ingenthr Matt Ingenthron
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty