Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-47992

[BP 7.0.2] - Plasma Stats Compact Counter not updated on CompactFullMarshal

    XMLWordPrintable

Details

    • Untriaged
    • 1
    • Unknown

    Description

      On Page Marshal, a page can get compacted if CompactFullMarshal is enabled. We are not updating the compacts counter in code paths involving LSSCleaner, Persist after a page is Marshalled.

       

      // Compact the page if going through full marshal
      func (pg *page) compactFullMarshal(maxSegments int) (bool, int, int) {
      if pg.ctx.CompactFullMarshal &&
      pg.head != nil &&
      pg.head.GetOp() != opBasePage &&
      pg.head.GetOp() != opPageRemoveDelta &&
      pg.head.GetOp() != opMetaDelta {
      // full marshal required?
      if_, fInfo := pg.findFlushInfo(); fInfo != nil {
      if fInfo.NumSegments > maxSegments {
      dataSz, hdrSz := pg.Compact()
      returntrue, dataSz, hdrSz
      }
      }
      }
      returnfalse, 0, 0
      }

       

      Attachments

        Issue Links

          For Gerrit Dashboard: MB-47992
          # Subject Branch Project Status CR V

          Activity

            Wayne Siu Please approve this fix for 7.0.2. This fixes a stats that was missed in one case. This will help in avoiding inconsistent stats. The fix is straightforward. Return value of a function changed causing a number of files to be updated but the impact is minimal. 

            srinath.duvuru Srinath Duvuru added a comment - Wayne Siu  Please approve this fix for 7.0.2. This fixes a stats that was missed in one case. This will help in avoiding inconsistent stats. The fix is straightforward. Return value of a function changed causing a number of files to be updated but the impact is minimal. 

            Build couchbase-server-7.0.2-6529 contains plasma commit 268b4b3 with commit message:
            MB-47992 [BP]: Fix compact count due to compactFullMarshal

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.2-6529 contains plasma commit 268b4b3 with commit message: MB-47992 [BP] : Fix compact count due to compactFullMarshal

            The change is straightforward and has unit tests to validate. No specific test needed.

            srinath.duvuru Srinath Duvuru added a comment - The change is straightforward and has unit tests to validate. No specific test needed.

            People

              saptarshi.sen Saptarshi Sen
              saptarshi.sen Saptarshi Sen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty