Details
-
Bug
-
Resolution: Fixed
-
Major
-
7.1.0
-
None
-
Triaged
-
1
-
No
-
KV-Engine Sprint 2021 August, KV-Engine-Sept-21
Description
An extension from MB-48033. We can save 6 bytes of every committed item by not storing the durability info. We already have a version field in the metadata to determine which version is which.
It makes sense to do this before Neo as we don't care about backward compatibility yet.
We can also shrink the bySeqno field by using cb::uint48_t and we can remove the vbid field if we pass it to the compaction context builder from magma.
Attachments
| For Gerrit Dashboard: MB-48034 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 159667,7 | MB-48034: Move magma metadata into version blocks | master | kv_engine | Status: MERGED | +2 | +1 |
| 159669,14 | MB-48034: Make magma MetaData variable length | master | kv_engine | Status: MERGED | +2 | +1 |
| 159800,8 | MB-48034: Shrink bySeqno in magma metadata | master | kv_engine | Status: MERGED | +2 | +1 |
| 159859,7 | MB-48034 magma: Add kvstoreID argument in compaction callback factory | master | magma | Status: MERGED | +2 | +1 |
| 159860,7 | MB-48034: Pass vbid to magma compaction context | master | kv_engine | Status: MERGED | +2 | +1 |
| 160216,1 | MB-48034: Use KV metadata directly | master | magma | Status: ABANDONED | 0 | 0 |
| 160632,3 | MB-48034: Remove vbid from magma metadata | master | kv_engine | Status: MERGED | +2 | +1 |
| 160633,1 | MB-48034: Remove vbid field from KV metadata | master | magma | Status: ABANDONED | 0 | -1 |
| 160635,4 | MB-48034: Remove vbid field from KV metadata | master | magma | Status: MERGED | +2 | +1 |
| 161089,3 | MB-48034: Wrap magma V0 bits in struct | master | kv_engine | Status: MERGED | +2 | +1 |
| 161090,8 | MB-48034: Leb128 various magma metadata fields | master | kv_engine | Status: MERGED | +2 | +1 |