Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-48691

XDCR - gomemcached - closing feed without startFeed may leave stray goroutine running

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 7.1.0
    • 7.1.0
    • gomemcached
    • None
    • 1

    Description

      Looking at logs from MB-48323, seeing a lot of stray go routines not being closed:

      172.23.123.24_20210903-012026/goxdcr_pprof.log

      goroutine profile: total 1007
      505 @ 0x43c9a5 0x44c88f 0x7515d4 0x471841
      #       0x7515d3        github.com/couchbase/gomemcached/client.(*UprFeed).sendCommands+0xf3    /home/couchbase/jenkins/workspace/couchbase-server-unix/goproj/src/github.com/couchbase/gomemcached/client/upr_feed.go:340
       
      180 @ 0x43c9a5 0x44c88f 0x92b271 0x471841
      #       0x92b270        github.com/couchbase/goxdcr/component.(*AsyncComponentEventListenerImpl).start+0x250    /home/couchbase/jenkins/workspace/couchbase-server-unix/goproj/src/github.com/couchbase/goxdcr/component/async_listener.go:68
       
      23 @ 0x43c9a5 0x4081ca 0x407f75 0xa9f386 0xa9f205 0x471841
      #       0xa9f385        github.com/couchbase/goxdcr/backfill_manager.(*BackfillRequestHandler).handleBackfillRequestWithArgs+0x145      /home/couchbase/jenkins/workspace/couchbase-server-unix/goproj/src/github.com/couchbase/goxdcr/backfill_manager/backfill_request_handler.go:379
      #       0xa9f204        github.com/couchbase/goxdcr/backfill_manager.(*BackfillRequestHandler).HandleBackfillRequest+0x44               /home/couchbase/jenkins/workspace/couchbase-server-unix/goproj/src/github.com/couchbase/goxdcr/backfill_manager/backfill_request_handler.go:360
      

      This is due to new P2P VB master check and merge code, and it is not clear if these will cause connections to not be removed.
      This will need to be fixed regardless.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              neil.huang Neil Huang
              neil.huang Neil Huang
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty