Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-49729

DCP system events should be considered encapsulated within OSO snapshots

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 7.0.2
    • 7.1.0
    • analytics
    • Untriaged
    • 1
    • Unknown
    • CX Sprint 274, CX Sprint 277

    Description

      The Collections spec states:

      During receipt of the OSO snapshot (i.e. begin received, but not the end) keep track of the greatest seqno received, consider this X.
      X = max(X, received message.seqno).
      The client must do this tracking for all DCP mutation, deletion, expiration and system events. If the client enabled synchronous replication, they would also need to include DCP prepare and abort messages.

      Analytics DCP client does not consider system events to be within the OSO snapshot tracking, this should be fixed in Neo.

      Attachments

        Issue Links

          For Gerrit Dashboard: MB-49729
          # Subject Branch Project Status CR V

          Activity

            Build couchbase-server-7.1.0-1901 contains analytics-dcp-client commit 13044bd with commit message:
            MB-49729: seqno advancements should be fully encapsulated within oso

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1901 contains analytics-dcp-client commit 13044bd with commit message: MB-49729 : seqno advancements should be fully encapsulated within oso

            Build couchbase-server-7.1.0-1901 contains cbas-core commit 378d826 with commit message:
            MB-49729: enable receipt of SEQNO_ADVANCED within an OSO snapshot

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-1901 contains cbas-core commit 378d826 with commit message: MB-49729 : enable receipt of SEQNO_ADVANCED within an OSO snapshot
            michael.blow Michael Blow added a comment -

            On review of the ingestion pipeline, I see an issue with the current implementation that prevents correct handling of SEQNO_ADVANCED within an oso snapshot; reopening

            michael.blow Michael Blow added a comment - On review of the ingestion pipeline, I see an issue with the current implementation that prevents correct handling of SEQNO_ADVANCED within an oso snapshot; reopening

            Build couchbase-server-7.1.0-2015 contains cbas-core commit 639f49f with commit message:
            Revert "MB-49729: enable receipt of SEQNO_ADVANCED within an OSO snapshot"

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-2015 contains cbas-core commit 639f49f with commit message: Revert " MB-49729 : enable receipt of SEQNO_ADVANCED within an OSO snapshot"

            Build couchbase-server-7.1.0-2026 contains cbas-core commit 1fc5fa5 with commit message:
            MB-49729: handle seqno advancements within an OSO snapshot

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.0-2026 contains cbas-core commit 1fc5fa5 with commit message: MB-49729 : handle seqno advancements within an OSO snapshot

            Verified as part of code review.

            murtadha.hubail Murtadha Hubail added a comment - Verified as part of code review.
            till Till Westmann added a comment - - edited

            Potentially causes skipped data on ingestion recovery - leading to wrong query results.

            till Till Westmann added a comment - - edited Potentially causes skipped data on ingestion recovery - leading to wrong query results.

            People

              murtadha.hubail Murtadha Hubail
              michael.blow Michael Blow
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  PagerDuty