Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Cannot make persistent change to num nonio/auxio threads

Description

Config params num_nonio_threads / num_auxio_threads set via ns_server extra_config_string are not respected.

cbepctl set flush_param still works, modifying the running config in a non-persistent fashion.

extra_config_string in general makes persistent changes to the config for a given bucket, which will survive a restart. This is a somewhat "canonical" method provided to customers by support to change settings in response to issues. Customers with these parameters currently set would find they no longer apply if upgrading to a build in the current state.

Code context:

kv_engine/daemon/memcached.cc

kv_engine/engines/ep/src/ep_engine.cc

This abandoned patch would move to these values being controlled by memcached settings, rather than bucket config, which makes sense as these have global impact.

Components

Affects versions

Fix versions

Labels

Environment

None

Link to Log File, atop/blg, CBCollectInfo, Core dump

None

Release Notes Description

None

Activity

Show:

CB robot January 14, 2022 at 2:37 AM

Build couchbase-server-7.1.0-2062 contains ns_server commit a0557f1 with commit message:
, Upgrade memcached_defaults

Steve Watanabe January 14, 2022 at 12:56 AM

Dave opened a separate bug to track the upgrade issue.

Dave Finlay January 13, 2022 at 1:59 AM

: lovely work finding and debugging this issue. (For folks following along, it turns out that this patch actually breaks offline ugprade.) Steve - I will assign to you; I think it's too much to ask folks from outside of ns_server to navigate the complexities of cluster compat mode upgrade.

Steve Watanabe January 13, 2022 at 1:41 AM

I chatted with Dave F. about this and he asked me to make the change.

Steve Watanabe January 13, 2022 at 1:29 AM

The ns_server fix broke upgrades. The new settings num_auxio_threads and num_nonio_threads shouldn't be added until the cluster_compat_mode is NEO. Here's an example in mad-hatter http://src.couchbase.org/source/xref/mad-hatter/ns_server/src/menelaus_web_mcd_settings.erl#32-54

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Is this a Regression?

Yes

Triage

Untriaged

Story Points

Sprint

Priority

Instabug

Open Instabug

PagerDuty

Sentry

Zendesk Support

Created December 8, 2021 at 10:58 AM
Updated October 13, 2023 at 11:47 AM
Resolved January 14, 2022 at 12:56 AM
Instabug