Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-50337

[TC] objstore 'TestClient' should use a RWMutex instead of a Mutex

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • Major
    • 7.1.0
    • 7.1.0
    • tools
    • None
    • 1

    Description

      What's the issue?
      The 'TestClient' currently uses a 'sync.Mutex' to guard access to the underlying bucket/object map; we should be using a 'sync.RWMutex'. This means we're seeing deadlocks in 'cbbackupmgr' unit testing.

      This won't guard against all potential deadlock conditions (e.g. iterating whilst creating new objects) but should cover our existing use case more sufficiently.

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. MB-53853 [TC] Use a sync.Map in TestClient

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. MB-53826 [TC][OBJ] Add function to upload zip of objects with a given prefix

          • Major - Major loss of function.
          • Resolved
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              james.lee James Lee
              james.lee James Lee
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty