Details
-
Bug
-
Resolution: Fixed
-
Blocker
-
1.8.1-release-candidate
-
Security Level: Public
-
None
Description
As part of fixing MB-5052 it's logs revealed that one of vbuckets we previously built using new code did not actually have closed checkpoint. So replica wasn't in fact built.
After discussion with Chiyoung I found that using 'backfill_completed' to find out when replica is mostly up-to-date is not correct. This stat becomes true when backfill is done, but there's also next message that opens next checkpoint. And we should be waiting for it instead. But we also found there are no producer-side stats we can use.
So we decided I'll have to additionally poll destinations for actually closed checkpoints on them before I'll stop replication building.
Attachments
For Gerrit Dashboard: MB-5136 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
15119,4 | MB-5136 Don't sleep if there are any new pending notifications. | branch-181 | ep-engine | Status: MERGED | +2 | +1 |
15186,2 | in replica building wait until destination has checkpoint.MB-5136 | branch-181 | ns_server | Status: MERGED | +2 | +1 |
15200,1 | Merge remote-tracking branch 'origin/branch-181' into branch-18 | branch-18 | ns_server | Status: MERGED | +2 | +1 |
15201,1 | Merge remote-tracking branch 'origin/branch-18' into merge | master | ns_server | Status: MERGED | +2 | +1 |
15261,1 | MB-5136 Don't sleep if there are any new pending notifications. | branch-18 | ep-engine | Status: MERGED | +2 | +1 |
15268,1 | Merge branch 'branch-18' | master | ep-engine | Status: ABANDONED | 0 | 0 |
15269,1 | Merge branch 'branch-18' | master | ep-engine | Status: ABANDONED | 0 | 0 |
15270,1 | Merge branch 'branch-18' | master | ep-engine | Status: ABANDONED | 0 | 0 |
15271,2 | Merge branch 'branch-18' | master | ep-engine | Status: MERGED | +2 | +1 |
16007,1 | better log pids of replica building participants | branch-181 | ns_server | Status: MERGED | +2 | +1 |
16008,1 | log if we have to sleep for open checkpoint when building replica | branch-181 | ns_server | Status: MERGED | +2 | +1 |