Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-51421

couch_dbdump: Always printing documents as explicitly deleted when should be TTL

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 6.5.0, 6.0.0, 6.0.1, 6.0.2, 6.0.3, 6.0.4, 6.5.1, 6.0.5, 6.6.0, 6.6.1, 6.6.2, 6.5.2, 7.0.0, 6.6.3, 7.0.3, 7.0.2, 7.0.1, 6.6.5, 6.6.4
    • 7.1.0, 7.0.4
    • storage-engine
    • Untriaged
    • 1
    • Unknown

    Description

      Couchstore stores the delete source in the top-bit of flex_code and couch_dbdump decodes the flex_code to find the "TTL" delete flag as follows:

      ttl_delete = ((metaV1->flex_code << 7) & 0x1) == 1;

      But that should be a right shift so will always print documents as explicitly deleted

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Ascending order - Click to sort in descending order
          View 11 older comments
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-7.2.0-5000 contains couchstore commit b35acc4 with commit message:
          MB-51421: [BP] couch_dbdump incorrect decode of flex_code for deletion source

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.2.0-5000 contains couchstore commit b35acc4 with commit message: MB-51421 : [BP] couch_dbdump incorrect decode of flex_code for deletion source
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-7.5.0-3003 contains couchstore commit 56b0f7b with commit message:
          MB-51421: Merge 'couchbase/cheshire-cat' into 'couchbase/neo'

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.5.0-3003 contains couchstore commit 56b0f7b with commit message: MB-51421 : Merge 'couchbase/cheshire-cat' into 'couchbase/neo'
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-7.5.0-3003 contains couchstore commit b35acc4 with commit message:
          MB-51421: [BP] couch_dbdump incorrect decode of flex_code for deletion source

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.5.0-3003 contains couchstore commit b35acc4 with commit message: MB-51421 : [BP] couch_dbdump incorrect decode of flex_code for deletion source
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-8.0.0-1132 contains couchstore commit 56b0f7b with commit message:
          MB-51421: Merge 'couchbase/cheshire-cat' into 'couchbase/neo'

          build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1132 contains couchstore commit 56b0f7b with commit message: MB-51421 : Merge 'couchbase/cheshire-cat' into 'couchbase/neo'
          build-team Couchbase Build Team added a comment -

          Build couchbase-server-8.0.0-1132 contains couchstore commit b35acc4 with commit message:
          MB-51421: [BP] couch_dbdump incorrect decode of flex_code for deletion source

          build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1132 contains couchstore commit b35acc4 with commit message: MB-51421 : [BP] couch_dbdump incorrect decode of flex_code for deletion source

          People

            jwalker Jim Walker
            jwalker Jim Walker
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                PagerDuty