Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-52383

Warmup of loading data does not yield correctly

    XMLWordPrintable

Details

    • Triaged
    • 1
    • Yes

    Description

      Currently we currently do not yield correctly during warmup (added by MB-47267) after we've spent 10ms loading data from disk. MB-47267 was originally created to help ensure that we warmup buckets more fairly.

      This bug bug is caused by us, not taking a reference to the callback in ScanContext which can be seen here (added in commit 423ad543ece154d405de06309601a3bc77f8f399). This commit was made as apart of the original change for MB-47267 so it means that the code has never worked as fully intended.

      To fix this we should change auto kvCallback = to auto& kvCallback =.

      This doesn't affect 6.6.4 or later as we never made a back port for 6.6.4 even though MB-48091 was created to do this.

      Attachments

        Issue Links

          For Gerrit Dashboard: MB-52383
          # Subject Branch Project Status CR V

          Activity

            Build couchbase-server-7.2.0-1928 contains kv_engine commit 5f6d5dc with commit message:
            MB-47267 / MB-52383: Make backfill during warmup a PauseResume task

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.2.0-1928 contains kv_engine commit 5f6d5dc with commit message: MB-47267 / MB-52383 : Make backfill during warmup a PauseResume task

            Build couchbase-server-8.0.0-1097 contains kv_engine commit 256c787 with commit message:
            Merge "MB-52383: Merge branch 'cheshire-cat' into neo" into neo

            build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1097 contains kv_engine commit 256c787 with commit message: Merge " MB-52383 : Merge branch 'cheshire-cat' into neo" into neo

            Build couchbase-server-8.0.0-1097 contains kv_engine commit 46014c7 with commit message:
            MB-52383: Merge branch 'cheshire-cat' into neo

            build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1097 contains kv_engine commit 46014c7 with commit message: MB-52383 : Merge branch 'cheshire-cat' into neo

            Build couchbase-server-8.0.0-1097 contains kv_engine commit 2a83a2a with commit message:
            MB-52383: Merge branch 'mad-hatter' into cheshire-cat

            build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1097 contains kv_engine commit 2a83a2a with commit message: MB-52383 : Merge branch 'mad-hatter' into cheshire-cat

            Build couchbase-server-8.0.0-1097 contains kv_engine commit 5f6d5dc with commit message:
            MB-47267 / MB-52383: Make backfill during warmup a PauseResume task

            build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1097 contains kv_engine commit 5f6d5dc with commit message: MB-47267 / MB-52383 : Make backfill during warmup a PauseResume task

            People

              richard.demellow Richard deMellow
              richard.demellow Richard deMellow
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                PagerDuty