Currently we currently do not yield correctly during warmup (added by
MB-47267) after we've spent 10ms loading data from disk. MB-47267 was originally created to help ensure that we warmup buckets more fairly.
This bug bug is caused by us, not taking a reference to the callback in ScanContext which can be seen here (added in commit 423ad543ece154d405de06309601a3bc77f8f399). This commit was made as apart of the original change for
MB-47267 so it means that the code has never worked as fully intended.
To fix this we should change auto kvCallback = to auto& kvCallback =.
This doesn't affect 6.6.4 or later as we never made a back port for 6.6.4 even though
MB-48091 was created to do this.
|For Gerrit Dashboard: MB-52383|
|175477,7||MB-52383: Ensure we yield correctly when loading data during warmup||master||kv_engine||Status: ABANDONED||0||+1|
|175496,4||MB-52383: Ensure we yield correctly when loading data during warmup||neo||kv_engine||Status: MERGED||+2||+1|
|175497,2||MB-52383: Ensure we yield correctly when loading data during warmup||cheshire-cat||kv_engine||Status: ABANDONED||0||-1|
|176167,2||MB-52383: Disable test_reader_thread_starvation_warmup||master||kv_engine||Status: MERGED||+2||+1|
|176369,3||MB-52383: Ensure EP config args for num_(reader|writer)_threads work||neo||kv_engine||Status: MERGED||+2||+1|
|176514,1||Merge commit 'neo' to master||master||kv_engine||Status: ABANDONED||0||0|
|176517,1||Merge commit 'neo' to master||master||kv_engine||Status: MERGED||+2||+1|
|177485,8||MB-47267 / MB-52383: Make backfill during warmup a PauseResume task||mad-hatter||kv_engine||Status: MERGED||+2||+1|
|177600,2||MB-47267: Make ObjectRegistry getAllocSize atomic||mad-hatter||kv_engine||Status: MERGED||+2||+1|
|178056,5||MB-53118: Ensure Warmup disk scans process at least 1 item||mad-hatter||kv_engine||Status: MERGED||+2||+1|
|178110,2||MB-53118: Ensure Warmup disk scan obeys yield limit||mad-hatter||kv_engine||Status: MERGED||+2||+1|
|178411,4||MB-52383: Merge branch 'mad-hatter' into cheshire-cat||cheshire-cat||kv_engine||Status: MERGED||+2||+1|
|178548,2||MB-52383: Merge branch 'cheshire-cat' into neo||neo||kv_engine||Status: MERGED||+2||+1|
|179282,1||Merge branch 'neo' into 'master'||master||kv_engine||Status: MERGED||+2||+1|