Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-52839

Tracing receives 0:0 spans when using ScopeTimer

    XMLWordPrintable

Details

    • Untriaged
    • 1
    • Unknown

    Description

      Every ScopeTimer that is constructed inadvertently copy-constructs the tuple members, meaning 1 temporary is created/destructed with no start/stop time. This leaves us with tracing that looks like:

      "trace":"request=11472086545592026:543384 get=0:0 bg.wait=11472086545601845:63 get=11472086545596216:18 execute=11472086545592026:23 bg.load=11472086545665306:543241 get=0:0 get=11472087088953283:10 execute=11472087088949455:27"
      

      This affects every get and store as they are the users of ScopeTimer.

      A fix (to be checked on all compilers...) is simple to ensure correct construction.

      This issue was introduced by https://review.couchbase.org/c/platform/+/166433 and shipped in 7.1.0

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            ashwin.govindarajulu Ashwin Govindarajulu
            jwalker Jim Walker
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                PagerDuty