Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-53282

early return in AuditFile::close_and_rotate_file don't reset open_time

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 6.6.1, 6.6.2, 7.0.0, 6.6.3, 7.1.0, 7.0.3, 7.0.2, 7.0.1, 6.6.5, 6.6.4, 7.1.1, 7.0.4
    • 7.1.2
    • memcached
    • Untriaged
    • 1
    • Unknown

    Description

      void AuditFile::close_and_rotate_log() {
      120      cb_assert(file);
      121      file.reset();
      122      if (current_size == 0) {
      123          remove(open_file_name.c_str());
      124          return;
      125      }
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          Trond Norbye - Following up as this is still targeted to 7.1.2. Goal is to take RC3 on Aug 5.  Please provide an updated ETA/comment if this is still targeted for 7.1.2 Thanks! 

          prachi.sikchi Prachi Sikchi (Inactive) added a comment - Trond Norbye - Following up as this is still targeted to 7.1.2. Goal is to take RC3 on Aug 5.  Please provide an updated ETA/comment if this is still targeted for 7.1.2 Thanks! 
          ritam.sharma Ritam Sharma added a comment -

          This is approved for 7.1.2 from QE.

          ritam.sharma Ritam Sharma added a comment - This is approved for 7.1.2 from QE.

          Build couchbase-server-7.1.2-3417 contains kv_engine commit 453eb9a with commit message:
          MB-53282: Reset open_time in early return in close_and_rotate_file

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.2-3417 contains kv_engine commit 453eb9a with commit message: MB-53282 : Reset open_time in early return in close_and_rotate_file

          Build couchbase-server-7.2.0-1846 contains kv_engine commit 453eb9a with commit message:
          MB-53282: Reset open_time in early return in close_and_rotate_file

          build-team Couchbase Build Team added a comment - Build couchbase-server-7.2.0-1846 contains kv_engine commit 453eb9a with commit message: MB-53282 : Reset open_time in early return in close_and_rotate_file

          Build couchbase-server-8.0.0-1084 contains kv_engine commit 453eb9a with commit message:
          MB-53282: Reset open_time in early return in close_and_rotate_file

          build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1084 contains kv_engine commit 453eb9a with commit message: MB-53282 : Reset open_time in early return in close_and_rotate_file

          People

            trond Trond Norbye
            trond Trond Norbye
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty