Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-53929

Fix views test failures caused by upgrade to v8 changing TypeError strings

    XMLWordPrintable

Details

    • Triaged
    • 1
    • Yes

    Description

      As reported in MB-53924, there are 2 view-engine tests that are failing on all platforms after the upgrade to v8. For instance on http://cv.jenkins.couchbase.com/job/couchstore.aarch64-linux/job/neo/5/console we see:

        9/13 Test #10: couchstore-mapreduce-map-test .......Subprocess aborted***Exception:   2.11 sec
       Running map tests
       assertion failed [strcmp("TypeError: Cannot read property 'bar' of undefined (line " "1:36)", result->list[0].result.error_msg) == 0] at ../couchstore/tests/mapreduce/map.cc:107
       Called from:
       	#0  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-map-test() [0x400000+0x58344]
       	#1  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-map-test() [0x400000+0x580a0]
       	#2  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-map-test() [0x400000+0x15ec4]
       	#3  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-map-test() [0x400000+0x17624]
       	#4  /lib64/libc.so.6(__libc_start_main+0xe4) [0xffff8d3e0000+0x1fce4]
       	#5  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-map-test() [0x400000+0x10ce0]
      

      And:

      13/13 Test #11: couchstore-mapreduce-reduce-test ....Subprocess aborted***Exception:   2.11 sec
       Running reduce tests
       assertion failed [strcmp("TypeError: Cannot read property 'bar' of undefined (line " "1:56)", error_msg) == 0] at ../couchstore/tests/mapreduce/reduce.cc:124
       Called from:
       	#0  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-reduce-test() [0x400000+0x57864]
       	#1  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-reduce-test() [0x400000+0x575c0]
       	#2  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-reduce-test() [0x400000+0x16098]
       	#3  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-reduce-test() [0x400000+0x16b44]
       	#4  /lib64/libc.so.6(__libc_start_main+0xe4) [0xffff9550e000+0x1fce4]
       	#5  /home/couchbase/jenkins/workspace/couchstore.aarch64-linux_neo/build/couchstore/couchstore_mapreduce-reduce-test() [0x400000+0x10ce0]
      

      Dave Rigby looked into these failures and found that they are caused by changed error messages that happen as a result of the v8 upgrade:

      First the good news - the first two test failures (couchstore-mapreduce-map-test & couchstore-mapreduce-reduce-test) which affect all platforms are just a test issue - the error message string returned from V8 when a JS function has an error during compilation has changed with the latest version of V8. We just need to tweak the expected messages in the test - see https://review.couchbase.org/c/couchstore/+/180667.

      Attachments

        Issue Links

          For Gerrit Dashboard: MB-53929
          # Subject Branch Project Status CR V

          Activity

            Build couchbase-server-7.1.2-3445 contains couchstore commit a18ecae with commit message:
            MB-53929: map-reduce tests: Update expected V8 error msg

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.1.2-3445 contains couchstore commit a18ecae with commit message: MB-53929 : map-reduce tests: Update expected V8 error msg

            Build couchbase-server-7.2.0-5000 contains couchstore commit a18ecae with commit message:
            MB-53929: map-reduce tests: Update expected V8 error msg

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.2.0-5000 contains couchstore commit a18ecae with commit message: MB-53929 : map-reduce tests: Update expected V8 error msg

            Build couchbase-server-7.5.0-3003 contains couchstore commit a18ecae with commit message:
            MB-53929: map-reduce tests: Update expected V8 error msg

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.5.0-3003 contains couchstore commit a18ecae with commit message: MB-53929 : map-reduce tests: Update expected V8 error msg

            Build couchbase-server-8.0.0-1132 contains couchstore commit a18ecae with commit message:
            MB-53929: map-reduce tests: Update expected V8 error msg

            build-team Couchbase Build Team added a comment - Build couchbase-server-8.0.0-1132 contains couchstore commit a18ecae with commit message: MB-53929 : map-reduce tests: Update expected V8 error msg

            People

              dfinlay Dave Finlay
              dfinlay Dave Finlay
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty