Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-53950

Connection management issues

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 6.6.6
    • 7.0.5
    • query
    • 1

    Description

      This MB tries to address the corner cases in which, after a failover, query does not ditch old data node or pick up new data nodes, and insists in picking up non responsive nodes in error.

      Attachments

        Issue Links

          For Gerrit Dashboard: MB-53950
          # Subject Branch Project Status CR V

          Activity

            marco.greco Marco Greco added a comment -

            Here's a list of defects that have made changes relevant to mad hatter connection management issues.
            Again, let's have it on record that these would require a major rewrite of go-couchbase and datastore/couchbase/couchbase.go on both 7.0 and 6.6 and they are not simple cherry picks.
            Some do have descriptions that are completely unrelated to failures to detect vbmap changes, but do have code changes that apply.
            On that vein, in many cases, it's not the whole fix that needs to be applied, but selected code.

            MB-39370
            MB-41065
            MB-41980
            MB-42753
            MB-44019
            MB-44328
            MB-45048
            MB-50172
            MB-50725

            I cannot exclude to have missed a few.

            Overall, it may work better to go through datastore/couchbase/couchbase.go and the primitives package, and amend the earlier code from the newer fixes.

            marco.greco Marco Greco added a comment - Here's a list of defects that have made changes relevant to mad hatter connection management issues. Again, let's have it on record that these would require a major rewrite of go-couchbase and datastore/couchbase/couchbase.go on both 7.0 and 6.6 and they are not simple cherry picks. Some do have descriptions that are completely unrelated to failures to detect vbmap changes, but do have code changes that apply. On that vein, in many cases, it's not the whole fix that needs to be applied, but selected code. MB-39370 MB-41065 MB-41980 MB-42753 MB-44019 MB-44328 MB-45048 MB-50172 MB-50725 I cannot exclude to have missed a few. Overall, it may work better to go through datastore/couchbase/couchbase.go and the primitives package, and amend the earlier code from the newer fixes.

            Build couchbase-server-7.0.5-7658 contains go-couchbase commit fb66b75 with commit message:
            MB-53950 initial commit

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.5-7658 contains go-couchbase commit fb66b75 with commit message: MB-53950 initial commit

            Build couchbase-server-7.0.5-7658 contains query commit bfc889f with commit message:
            MB-53950 initial commit

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.5-7658 contains query commit bfc889f with commit message: MB-53950 initial commit
            marco.greco Marco Greco added a comment -

            There might be an extra improvement that could be done, but I haven't even tried it on master, let alone back ported it, so we'll probably leave it for 7.0.6.

            marco.greco Marco Greco added a comment - There might be an extra improvement that could be done, but I haven't even tried it on master, let alone back ported it, so we'll probably leave it for 7.0.6.

            Build couchbase-server-7.0.6-8007 contains go-couchbase commit fb66b75 with commit message:
            MB-53950 initial commit

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.6-8007 contains go-couchbase commit fb66b75 with commit message: MB-53950 initial commit

            Build couchbase-server-7.0.6-8007 contains query commit bfc889f with commit message:
            MB-53950 initial commit

            build-team Couchbase Build Team added a comment - Build couchbase-server-7.0.6-8007 contains query commit bfc889f with commit message: MB-53950 initial commit

            Tested with 7.0.5-7658+

            pierre.regazzoni Pierre Regazzoni added a comment - Tested with 7.0.5-7658+

            People

              pierre.regazzoni Pierre Regazzoni
              Sitaram.Vemulapalli Sitaram Vemulapalli
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty