Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-54300

[BP to 6.6.6 MB-51318] Potential for request stall if stream operator fails to notify request that it has terminated

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 6.5.2, 7.1.0, 7.0.3, 6.6.5
    • 6.6.6
    • query
    • Untriaged
    • 1
    • No

    Description

      In order to avoid panics and garbled json responses, the main ServeHTTP request needs to know that the Stream operator is dead before continuing after a network close / timeout / request termination / assert failure.
      Although there is no testcase, and code inspection has found nothing, if Stream fails to notify for whatever reason, this code path will lead to a hang, and there is at least one CBSE showing these symptoms.
      Proactively find ways to remove this weakness, while not affecting throughput.

      Attachments

        Issue Links

          backports to

          Bug - A problem which impairs or prevents the functions of the product. MB-54043 [BP 7.1.3/7.2.0 MB-51318] Potential for request stall if stream operator fails to notify request that it has terminated

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-54236 [BP 7.0.5 MB-51318] Potential for request stall if stream operator fails to notify request that it has terminated

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MB-54417 [BP 7.1.x MB-51318] Potential for request stall if stream operator fails to notify request that it has terminated

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is a backport of

          Bug - A problem which impairs or prevents the functions of the product. MB-51318 Potential for request stall if stream operator fails to notify request that it has terminated

          • Major - Major loss of function.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            Ascending order - Click to sort in descending order
            ajay.bhullar Ajay Bhullar added a comment -

            it seems like there are no cases to verify this specific bug? So its just a matter of making sure nothing is broken?

            ajay.bhullar Ajay Bhullar added a comment - it seems like there are no cases to verify this specific bug? So its just a matter of making sure nothing is broken?
            marco.greco Marco Greco added a comment -

            This is another one that we have seen in the field but have no repro.

            marco.greco Marco Greco added a comment - This is another one that we have seen in the field but have no repro.
            build-team Couchbase Build Team added a comment -

            Build couchbase-server-6.6.6-10565 contains query commit 0662bcb with commit message:
            MB-54300 avoid waiting on result channel on stop or close

            build-team Couchbase Build Team added a comment - Build couchbase-server-6.6.6-10565 contains query commit 0662bcb with commit message: MB-54300 avoid waiting on result channel on stop or close
            pavan.pb Pavan PB added a comment -

            No panics were seen with system test run on 6.6.6-10573. Closing this out.

            pavan.pb Pavan PB added a comment - No panics were seen with system test run on 6.6.6-10573. Closing this out.

            People

              pavan.pb Pavan PB
              Sitaram.Vemulapalli Sitaram Vemulapalli
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty