Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-54447

XDCR - "validateTargetTopology completed" shown even though it may have failed

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Morpheus
    • 6.6.0, 6.6.1, 6.6.2, 6.6.3, 6.6.4, 6.6.5, 7.0.0, 7.0.1, 7.0.2, 7.0.3, 7.0.4, 7.1.0, 7.1.1, 7.1.2
    • XDCR
    • None
    • Untriaged
    • 1
    • Unknown

    Description

      func (top_detect_svc *TopologyChangeDetectorSvc) validateTargetTopology() ([]uint16, map[uint16]string, error) {
      	defer top_detect_svc.logger.Infof("TopologyChangeDetectorSvc for pipeline %v validateTargetTopology completed", top_detect_svc.pipeline.Topic())
       
      	targetClusterCompatibility, targetServerVBMap, err := top_detect_svc.getTargetBucketInfo()
       
      	if err != nil {
      		top_detect_svc.logger.Warnf("Skipping target check since received error retrieving target bucket info for %v. err=%v", top_detect_svc.pipeline.Topic(), err)
      		return nil, nil, err
      	}
      

      If an error occurs, the word "completed" should not be printed.

      In the latest master as of 7.1, the code is along the lines of:

      func (top_detect_svc *TopologyChangeDetectorSvc) handleTargetTopologyChange(diff_vb_list []uint16, target_vb_server_map map[uint16]string, err_in error) error {
      	defer top_detect_svc.logger.Infof("TopologyChangeDetectorSvc for pipeline %v handleTargetTopologyChange completed", top_detect_svc.mainPipelineTopic)
       
      	var err error
      	// first check if relevant problematic vbs in pipeline are due to target topology changes.
      	// the if conditions are to ensure that diff_vb_list is valid
      	if err_in == nil || err_in == target_topology_changedErr {
      		err = top_detect_svc.validateVbErrors(diff_vb_list, false /*source*/)
      		if err != nil {
      			return err
      		}
      	}
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            sumukh.bhat Sumukh Bhat
            neil.huang Neil Huang
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty