Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-54976

Investigate implementing EventuallyPersistentEngine::deleteVBucket in terms of KVBucket::setVBucketState

    XMLWordPrintable

Details

    • Triaged
    • 0
    • No

    Description

      The current path for DEL_VBUCKET commands hits the function EventuallyPersistentEngine::deleteVBucket which is implemented partially in KVBucket::deleteVBucket. The general path for changing a vBucket state is in KVBucket::setVBucketState however and it is easy to forget that vBuckets can change state (to dead) via the DEL_VBUCKET path when adding to the code there. Investigate implementing the DEL_VBUCKET path in terms of KVBucket::setVBucketState so that all vBucket state changes are implemented in one place in the code.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              pavlos.georgiou Pavlos Georgiou
              ben.huddleston Ben Huddleston
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                PagerDuty