Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-57339

[TC] Pass in context to credential interface

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • master
    • master
    • tools-common
    • None
    • Untriaged
    • 0
    • Unknown

    Description

      What's the issue?

      Since fetching the credentials could be a REST API request we should accept a context in the interface parameters that would benefit from the parent timeouts or cancelation.

      The method in question is `GetCredentials` here: https://github.com/couchbase/tools-common/blob/d56ba2fc604aa058f6283cefb2e4183adf65e0e4/aprov/provider.go#L3-L8

      It would also be useful to consider if we should pass in the context to `GetUserAgent`

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            james.lee James Lee
            Gvidas.Razevicius Gvidas Razevicius
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty