Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-57908

Force enableExclude to false when ExcludeNode "in"/"inout" is enabled on all keepNodes and newNodes

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • bug-backlog
    • 7.2.1
    • secondary-index
    • None
    • Untriaged
    • 0
    • Unknown

    Description

      Currently in the adjustInitialSolutionIfNecessary function, enableExclude flag is set to falseusing the following condition

      // if there is deleted node and all nodes are excluded to take in new indexes,// then do not enable node exclusion
      if s.numDeletedNode != 0 && s.findNumExcludeInNodes() == len(s.Placement) {
            s.enableExclude = false
      }
       

      here the condition of checking should not be len(s.Placement) rather we will need to check if all the keepNodes & all the emptyNodes (considered to be newNodes by planner) has ExcludeNode "in" enabled. This is done as initially the solution will consider even the Nodes to be ejected/deleted in the Placement slice

       

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            shivansh.rustagi Shivansh Rustagi
            shivansh.rustagi Shivansh Rustagi
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty