Description
If a service have resources that can be partitioned and need to be distributed across multiple nodes, then, it can utilise cbgt to do so.
One such service is Sync-Gateway. It use cbgt for DCP feed sharding across multiple nodes.
https://review.couchbase.org/c/cbgt/+/161467 removed PLAN_PINDEXES_KEY from the list of keys that janitor loop subscribe to.
This change was done to avoid redundant cfg get operations and was a valid change for users of cfgMetaKV.
CfgMetaKV's set operation on PLAN_PINDEXES_KEY also update the value of PLAN_PINDEXES_DIRECTORY_STAMP. Thus making janitor subscribe to PLAN_PINDEXES_DIRECTORY_STAMP is enough.
But, Non-metakv cfg implementation (like cfgMem or Sync-gateway's implemention) do not tie updates to PlanPindexes with PLAN_PINDEXES_DIRECTORY_STAMP.
This resulted in missing janitor kicks for such implementations.
Even for the old metaKV implementation ( which use sharedPlan instead of LeanPlan , protected by feature flag LeanPlanVersion ), this change is a problem.
We want cbgt to keep PLAN_PINDEXES_KEY in the list of keys that janitor subscribe to. (Only for metakV implementation with LeanPlanVersion, we can choose to not keep it )
Attachments
For Gerrit Dashboard: MB-59249 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
199404,3 | MB-59249 overridable planner/janitor sub keys | master | cbgt | Status: ABANDONED | -1 | 0 |
199407,1 | MB-59249 override janitor subscription keys | master | cbft | Status: ABANDONED | -1 | +1 |
199416,1 | MB-59249 conditional janitor subscription keys | master | cbgt | Status: ABANDONED | -1 | +1 |
199419,1 | MB-59249 set "cfg" to "metakv" in Manager options | master | cbft | Status: ABANDONED | -1 | +1 |
199512,5 | MB-59249: add planner/janitor loop sub-keys registry | master | cbgt | Status: ABANDONED | -1 | 0 |
199513,4 | MB-59249: set options["cfg"] for NewManagerEx | master | cbft | Status: MERGED | +2 | +1 |
199650,18 | MB-59249: Add cfg subscription keys registry | master | cbgt | Status: MERGED | +2 | +1 |
200004,1 | MB-59249: Add cfg subscription keys registry | trinity | cbgt | Status: ABANDONED | 0 | 0 |