Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-60438

Review and possibly remove legacy consumer-buffer logic in PassiveStream::streamEnd

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Major
    • Morpheus
    • 7.6.0
    • couchbase-bucket
    • None
    • 0

    Description

          if (res == cb::engine_errc::success) {
              // Stream End message successfully passed to stream. Can now remove
              // the stream from the streams map as it has completed its lifetime.
              removeStream(vbucket);
       
              // @todo MB-60438: Review and possibly remove
              // Note we are potentially racing with the consumer buffering task
              // which may call setDead, so we don't call setDead here (that could be
              // state transition violation/exception), hence we just move out the
              // flow control bytes (could be 0) and ensure they are accounted for.
              flowControl.incrFreedBytes(stream->moveFlowControlBytes());
          }
      

      Attachments

        Issue Links

          For Gerrit Dashboard: MB-60438
          # Subject Branch Project Status CR V

          Activity

            People

              paolo.cocchi Paolo Cocchi
              paolo.cocchi Paolo Cocchi
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes

                  PagerDuty