Details
-
Bug
-
Resolution: Fixed
-
Blocker
-
Morpheus
-
None
-
Untriaged
-
0
-
Unknown
Description
when trying to build with Microsoft Visual Studio 2022 we're encountering an error caused by
Status CreateFile(std::string path);
|
(it fails building config.cc as its included one of the windows headers which does a #define CreateFile to either CreateFileA or CreateFileW depending on the configuration.
I guess the easiest solution to this problem would be to rename the function to something which don't clash with Visual Studios #define.
This is currently blocking the upgrade of the windows compilers (which is blocking upgrading folly; transition to C++20 etc)
Attachments
For Gerrit Dashboard: MB-61058 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
206893,3 | MB-61058 magma: Rename CreateFile to MakeFile | master | magma | Status: MERGED | +2 | +1 |