Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-61058

Compile failures with Microsoft Visual Studio 2022

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Morpheus
    • Morpheus
    • storage-engine
    • None
    • Untriaged
    • 0
    • Unknown

    Description

      when trying to build with Microsoft Visual Studio 2022 we're encountering an error caused by

      Status CreateFile(std::string path); 

       

      (it fails building config.cc as its included one of the windows headers which does a #define CreateFile to either CreateFileA or CreateFileW depending on the configuration.

      I guess the easiest solution to this problem would be to rename the function to something which don't clash with Visual Studios #define.

      This is currently blocking the upgrade of the windows compilers (which is blocking upgrading folly; transition to C++20 etc)

      Attachments

        For Gerrit Dashboard: MB-61058
        # Subject Branch Project Status CR V

        Activity

          People

            apaar.gupta Apaar Gupta
            trond Trond Norbye
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty