Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-61692

[TC] Upgrade golangci and clean cache

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • master
    • master
    • tools-common
    • None
    • Untriaged
    • 0
    • Unknown

    Description

      What's the issue?

      We have run into a false positive golangci error where it claims that a nolint directive is not used when in reality it is:

      + golangci-lint run --config ../.golangci.yml --timeout=10m
      tls/config_test.go:116:50: directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)
      		require.Len(t, config.ClientCAs.Subjects(), 1) //nolint:staticcheck
      		                                               ^
      tls/config_test.go:147:68: directive `//nolint:staticcheck` is unused for linter "staticcheck" (nolintlint)
      	require.Len(t, config.RootCAs.Subjects(), len(pool.Subjects())+1) //nolint:staticcheck 

      We have found an issue raised about this on github: https://github.com/golangci/golangci-lint/issues/3228

      What's the fix?

      Clean the cache as per the issue comments which claim that should fix the issue. Also as part of this we will also upgrade the golangci version to the latest one.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Gvidas.Razevicius Gvidas Razevicius
            Gvidas.Razevicius Gvidas Razevicius
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty