Details
-
Bug
-
Resolution: Unresolved
-
Major
-
7.2.5
-
None
-
Triaged
-
0
-
Unknown
-
March-June 24
Description
https://review.couchbase.org/c/kv_engine/+/210792/1/engines/ep/src/warmup.cc
case scan_again: {
|
const auto paused = kvCallback.isPausedDueToDeadLine();
|
// Legacy comment:
|
// "if the 'scan_again' was due to a OOM (e.i. not due to our deadline
|
// being met)causing warmup to be completed then log this and return
|
// false as we shouldn't keep scanning this vbucket"
|
//
|
// Note: At the time of writing I'm removing a useless class variable
|
// and pushing a no-logic-change. But, the following logic does the
|
// opposite of what declared in the legacy comment above. Ie:
|
// - by comment -> if paused:false we should return false
|
// - actually -> we return true
|
//
|
// Addressing in a dedicated change. @todo MB-62063
|
if (!paused) {
|
// skip loading remaining VBuckets as memory limit was reached
|
EP_LOG_INFO(
|
"WarmupVbucketVisitor::visit(): {} shardId:{} "
|
"lastReadSeqno:{} vbucket memory limit has been reached",
|
vb.getId(),
|
backfillTask.getShardId(),
|
currentScanCtx->lastReadSeqno);
|
// Backfill canceled due to OOM so destroy the scan ctx
|
currentScanCtx.reset();
|
}
|
return !paused;
|
}
|