Uploaded image for project: 'Couchbase Server'
  1. Couchbase Server
  2. MB-62172

Fix intermittent test failures in item_pager_test.cc

    XMLWordPrintable

Details

    • Untriaged
    • 0
    • Unknown

    Description

      See the following failure in tests infrequently.

       
      [ RUN ] EphemeralOrPersistent/STItemPagerTest.ServerQuotaReached/magma_persistent_quota_sharing_full_eviction_item_eviction_strategy_learning_age_and_mfu [2024-06-04T05:54:52.554Z] /home/couchbase/jenkins/workspace/kv_engine.aarch64-linux_master/kv_engine/engines/ep/tests/module_tests/item_pager_test.cc:742: Failure [2024-06-04T05:54:52.554Z] Expected: (count) >= (5), actual: 4 vs 5 [2024-06-04T05:54:52.554Z] Too few documents stored [2024-06-04T05:54:52.554Z] [2024-06-04T05:54:52.554Z] [ FAILED ] EphemeralOrPersistent/STItemPagerTest.ServerQuotaReached/magma_persistent_quota_sharing_full_eviction_item_eviction_strategy_learning_age_and_mfu, where GetParam() = "backend=magma:bucket_type=persistent:cross_bucket_ht_quota_sharing=true:item_eviction_policy=full_eviction:item_eviction_strategy=learning_age_and_mfu" (74 ms) EphemeralOrPersistent/STItemPagerTest.ServerQuotaReached/magma_persistent_quota_sharing_full_eviction_item_eviction_strategy_learning_age_and_mfu
      
      

      As a part of checking if the item pager is run:

      1. A vbucket is filled with items via populateUntilOOM in ServerQuotaReached test.
      2. populateUntilOOM adds ~ 10 documents.
      3. We assert in ServerQuotaReached test if the number of documents added is > 5.

      Assert in Step 3 could be a softer check i.e the number of documents loaded is > 0 vs what we are currently expecting it to be (> 5).

      The larger question is how is that we hit the OOM by just adding 4 items - I presume it's due to some new data-structures in Morpheus which is throwing off the calculation in populateUntilOOM.

      Attachments

        1. Memory usage.png
          Memory usage.png
          30 kB
        2. Memory usage per item.png
          Memory usage per item.png
          23 kB
        3. Mem-usage.png
          Mem-usage.png
          29 kB
        4. Mem-usage-per-item.png
          Mem-usage-per-item.png
          22 kB
        For Gerrit Dashboard: MB-62172
        # Subject Branch Project Status CR V

        Activity

          People

            hareen.kancharla Hareen Kancharla
            hareen.kancharla Hareen Kancharla
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes

                PagerDuty