Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta
    • Fix Version/s: 3.0
    • Component/s: couchbase-bucket
    • Security Level: Public
    • Labels:
      None

      Description

      From looking through the code it appears that it is unnecessary for their to be any warmup logic in the couch-kvstore code. It appears that reading the mutation log simply does muli-gets and this should be done from a high level. Moving this out will allow us to build and write unit tests against couch-kvstore.

      No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

        Hide
        mikew Mike Wiederhold added a comment -

        This is resolved, but we are holding off on merging the code until 2.1

        Show
        mikew Mike Wiederhold added a comment - This is resolved, but we are holding off on merging the code until 2.1
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ep-engine-2-0 #483 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/483/)
        MB-6368: Remove multiple variable tracking warmup status (Revision b2e277374f88b0110f3d47e3526e82c96e3886f5)
        MB-6368: Move warmup logic out of kvstore (Revision 5c742db3576f920e2ce777e3f24d6036a6da95c9)

        Result = SUCCESS
        Mike Wiederhold :
        Files :

        • src/ep.cc
        • src/ep_engine.cc
        • src/couch-kvstore/couch-kvstore.cc
        • src/ep_engine.h
        • src/stats.hh

        Mike Wiederhold :
        Files :

        • src/warmup.cc
        • src/couch-kvstore/couch-kvstore.cc
        • src/kvstore.cc
        • src/couch-kvstore/couch-kvstore.hh
        • src/kvstore.hh
        • src/warmup.hh
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #483 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/483/ ) MB-6368 : Remove multiple variable tracking warmup status (Revision b2e277374f88b0110f3d47e3526e82c96e3886f5) MB-6368 : Move warmup logic out of kvstore (Revision 5c742db3576f920e2ce777e3f24d6036a6da95c9) Result = SUCCESS Mike Wiederhold : Files : src/ep.cc src/ep_engine.cc src/couch-kvstore/couch-kvstore.cc src/ep_engine.h src/stats.hh Mike Wiederhold : Files : src/warmup.cc src/couch-kvstore/couch-kvstore.cc src/kvstore.cc src/couch-kvstore/couch-kvstore.hh src/kvstore.hh src/warmup.hh
        Hide
        thuan Thuan Nguyen added a comment -

        Integrated in github-ep-engine-2-0 #485 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/485/)
        MB-6368: Add force shutdown variable to stats.hh (Revision b9e629b31b9d78c65da00f3def8067361ad18320)
        MB-6368: Move EventuallyPersistentEngine refs out of kvstore (Revision 51a2903a069014c2d06c1723da93762c8aa80e01)

        Result = SUCCESS
        Mike Wiederhold :
        Files :

        • src/stats.hh
        • src/ep_engine.h
        • src/ep_engine.cc
        • src/ep.cc
        • src/couch-kvstore/couch-notifier.cc

        Mike Wiederhold :
        Files :

        • src/ep_engine.h
        • src/couch-kvstore/couch-notifier.hh
        • src/kvstore.cc
        • src/kvstore.hh
        • src/tapconnection.cc
        • src/stats.hh
        • src/couch-kvstore/couch-notifier.cc
        • src/ep_engine.cc
        • src/couch-kvstore/couch-kvstore.hh
        • src/couch-kvstore/couch-kvstore-dummy.hh
        • Makefile.am
        • src/warmup.cc
        • src/couch-kvstore/couch-kvstore.cc
        • src/ep.cc
        • src/couch-kvstore/couch-kvstore-dummy.cc
        Show
        thuan Thuan Nguyen added a comment - Integrated in github-ep-engine-2-0 #485 (See http://qa.hq.northscale.net/job/github-ep-engine-2-0/485/ ) MB-6368 : Add force shutdown variable to stats.hh (Revision b9e629b31b9d78c65da00f3def8067361ad18320) MB-6368 : Move EventuallyPersistentEngine refs out of kvstore (Revision 51a2903a069014c2d06c1723da93762c8aa80e01) Result = SUCCESS Mike Wiederhold : Files : src/stats.hh src/ep_engine.h src/ep_engine.cc src/ep.cc src/couch-kvstore/couch-notifier.cc Mike Wiederhold : Files : src/ep_engine.h src/couch-kvstore/couch-notifier.hh src/kvstore.cc src/kvstore.hh src/tapconnection.cc src/stats.hh src/couch-kvstore/couch-notifier.cc src/ep_engine.cc src/couch-kvstore/couch-kvstore.hh src/couch-kvstore/couch-kvstore-dummy.hh Makefile.am src/warmup.cc src/couch-kvstore/couch-kvstore.cc src/ep.cc src/couch-kvstore/couch-kvstore-dummy.cc
        Hide
        chiyoung Chiyoung Seo added a comment -

        I think Mike already did bunch of refactoring and merged it.

        Show
        chiyoung Chiyoung Seo added a comment - I think Mike already did bunch of refactoring and merged it.

          People

          • Assignee:
            tommie Tommie McAfee
            Reporter:
            mikew Mike Wiederhold
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Gerrit Reviews

              There are no open Gerrit changes